Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Cary Coutant <ccoutant@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>,
	gdb-patches@sourceware.org,        Doug Evans <dje@google.com>
Subject: Re: Regression for .debug_types [Re: [patch] Allow dummy CUs created by incremental linker]
Date: Thu, 20 Oct 2011 22:35:00 -0000	[thread overview]
Message-ID: <CAHACq4qnyaCRdv=qn2yFcOa=AD+maJv-KsQHu7+MU7yk7_HLKg@mail.gmail.com> (raw)
In-Reply-To: <CAHACq4p7kdYebtdBNrXbcXpztY8NOn3rs66_21vbGCoae254zA@mail.gmail.com>

> 2011-10-20  Cary Coutant  <ccoutant@google.com>
>
>        * dwarf2read.c (dw2_get_file_names): Move adjustment for type
>        section to...
>        (partial_read_comp_unit_head): ...here.  Add is_debug_type_section
>        flag.  Adjust all callers.
>        (process_psymtab_comp_unit): Remove adjustment for type section.

> Running the tests now, with -gdwarf4 explicitly turned on.

Tests completed, showing no regressions relative to a build of gdb
from just before my first patch yesterday. OK to commit?

(Apologies for the screw-up. I thought I was running the test suite
with -gdwarf4 enabled, but I wasn't using the right wrapper script. I
fixed that, and verified that the tests are now using .debug_types
sections.)

-cary


  reply	other threads:[~2011-10-20 22:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-19  0:44 [patch] Allow dummy CUs created by incremental linker Cary Coutant
2011-10-19 15:27 ` Tom Tromey
2011-10-19 15:52   ` Cary Coutant
2011-10-20 15:00     ` Regression for .debug_types [Re: [patch] Allow dummy CUs created by incremental linker] Jan Kratochvil
2011-10-20 19:16       ` Cary Coutant
2011-10-20 22:35         ` Cary Coutant [this message]
2011-10-21  0:00           ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHACq4qnyaCRdv=qn2yFcOa=AD+maJv-KsQHu7+MU7yk7_HLKg@mail.gmail.com' \
    --to=ccoutant@google.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox