From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26150 invoked by alias); 20 Oct 2011 22:09:46 -0000 Received: (qmail 26141 invoked by uid 22791); 20 Oct 2011 22:09:45 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_GD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Oct 2011 22:09:29 +0000 Received: from wpaz17.hot.corp.google.com (wpaz17.hot.corp.google.com [172.24.198.81]) by smtp-out.google.com with ESMTP id p9KM9RGk013885 for ; Thu, 20 Oct 2011 15:09:28 -0700 Received: from yxn16 (yxn16.prod.google.com [10.190.4.80]) by wpaz17.hot.corp.google.com with ESMTP id p9KM2gm9001404 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 20 Oct 2011 15:09:26 -0700 Received: by yxn16 with SMTP id 16so4319687yxn.0 for ; Thu, 20 Oct 2011 15:09:26 -0700 (PDT) Received: by 10.101.156.14 with SMTP id i14mr2785160ano.152.1319148566527; Thu, 20 Oct 2011 15:09:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.156.14 with SMTP id i14mr2785154ano.152.1319148566343; Thu, 20 Oct 2011 15:09:26 -0700 (PDT) Received: by 10.100.154.19 with HTTP; Thu, 20 Oct 2011 15:09:26 -0700 (PDT) In-Reply-To: References: <20111020145541.GA31871@host1.jankratochvil.net> Date: Thu, 20 Oct 2011 22:35:00 -0000 Message-ID: Subject: Re: Regression for .debug_types [Re: [patch] Allow dummy CUs created by incremental linker] From: Cary Coutant To: Jan Kratochvil Cc: Tom Tromey , gdb-patches@sourceware.org, Doug Evans Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00581.txt.bz2 > 2011-10-20 =A0Cary Coutant =A0 > > =A0 =A0 =A0 =A0* dwarf2read.c (dw2_get_file_names): Move adjustment for t= ype > =A0 =A0 =A0 =A0section to... > =A0 =A0 =A0 =A0(partial_read_comp_unit_head): ...here. =A0Add is_debug_ty= pe_section > =A0 =A0 =A0 =A0flag. =A0Adjust all callers. > =A0 =A0 =A0 =A0(process_psymtab_comp_unit): Remove adjustment for type se= ction. > Running the tests now, with -gdwarf4 explicitly turned on. Tests completed, showing no regressions relative to a build of gdb from just before my first patch yesterday. OK to commit? (Apologies for the screw-up. I thought I was running the test suite with -gdwarf4 enabled, but I wasn't using the right wrapper script. I fixed that, and verified that the tests are now using .debug_types sections.) -cary