From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1450 invoked by alias); 19 Oct 2011 14:40:42 -0000 Received: (qmail 1439 invoked by uid 22791); 19 Oct 2011 14:40:41 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Oct 2011 14:40:18 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9JEeHgN032608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Oct 2011 10:40:17 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p9JEeHck017573; Wed, 19 Oct 2011 10:40:17 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p9JEeFIu021700; Wed, 19 Oct 2011 10:40:16 -0400 From: Tom Tromey To: Cary Coutant Cc: gdb-patches@sourceware.org, Doug Evans Subject: Re: [patch] Allow dummy CUs created by incremental linker References: Date: Wed, 19 Oct 2011 15:27:00 -0000 In-Reply-To: (Cary Coutant's message of "Tue, 18 Oct 2011 17:30:16 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00529.txt.bz2 >>>>> "Cary" == Cary Coutant writes: Cary> With the new incremental linking support in gold, we leave patch space Cary> in the file at link time, and use that patch space for incremental Cary> updates. If the file has debug info, that means that the debug info Cary> might have "holes" in it. Because the debugger can't deal with Cary> arbitrary holes in the debug info, gold fills the holes with dummy Cary> compilation units, where each dummy CU consists of a compilation unit Cary> header whose length field cover the hole, and the rest of the space Cary> filled with zeroes. This patch updated gdb to tolerate these dummy Cary> CUs, by checking for an empty CU before attempting to read the DIEs. Thanks. Cary> +static unsigned int Cary> +peek_abbrev_code (bfd *abfd, gdb_byte *info_ptr) Cary> +{ Cary> + unsigned int bytes_read; Cary> + return read_unsigned_leb128 (abfd, info_ptr, &bytes_read); Our coding style requires a newline after the declarations. Ok with that change. Tom