Re: [PATCH 03/10] C language

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Monday, June 04 2012, Tom Tromey wrote:

> Sergio> +#define	yyparse	_c_parse
>
> It is pedantically better to avoid names with a leading underscore.
> While it probably will never cause any problem in practice, I think it
> is also just as easy to pick pedantically-correct names at the outset.
>
> So, could you rename these to $LANG_parse_internal or something like
> that?

Yeah, some languages were already using $LANG_parse_internal.  You're
right, I will use this pattern instead of _$LANG.

> Sergio> -  result = yyparse ();
> Sergio> +  result = _c_parse ();
>
> I think you don't need to change this line.
>
> From a spot check it appears these comments apply to all the other yacc
> parsers in the series.

Ok, I will revert all those changes to `yyparse' instead of `_$LANG'.

Thanks,

-- 
Sergio