From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: tromey@redhat.com
Cc: sergiodj@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 03/10] C language
Date: Mon, 04 Jun 2012 20:42:00 -0000 [thread overview]
Message-ID: <201206042042.q54Kg4mU002330@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <87lik2n7ik.fsf@fleche.redhat.com> (message from Tom Tromey on Mon, 04 Jun 2012 14:31:47 -0600)
> From: Tom Tromey <tromey@redhat.com>
> Date: Mon, 04 Jun 2012 14:31:47 -0600
>
> Sergio> +#define yyparse _c_parse
>
> It is pedantically better to avoid names with a leading underscore.
> While it probably will never cause any problem in practice, I think it
> is also just as easy to pick pedantically-correct names at the outset.
>
> So, could you rename these to $LANG_parse_internal or something like that?
I hesitated to bring it up, but when I was looking into using the yacc
-p option to get rid of the #defines, the underscored names posed a
problem.
So if you go through the trouble of renaming things, it might make
sense to use a consistent prefix ($LANG_) and give the wrappers
different names.
next prev parent reply other threads:[~2012-06-04 20:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-02 19:33 [PATCH 00/10] Remove `expout*' globals from parser-defs.h Sergio Durigan Junior
2012-06-02 19:33 ` [PATCH 02/10] SystemTap integration Sergio Durigan Junior
2012-06-04 20:23 ` Tom Tromey
2012-06-02 19:33 ` [PATCH 01/10] Language independent bits Sergio Durigan Junior
2012-06-04 20:20 ` Tom Tromey
2012-06-05 0:39 ` Sergio Durigan Junior
2012-06-02 19:34 ` [PATCH 03/10] C language Sergio Durigan Junior
2012-06-04 4:25 ` Doug Evans
2012-06-04 4:32 ` Sergio Durigan Junior
2012-06-04 20:32 ` Tom Tromey
2012-06-04 20:39 ` Sergio Durigan Junior
2012-06-04 20:42 ` Mark Kettenis [this message]
2012-06-04 20:49 ` Sergio Durigan Junior
2012-06-04 21:19 ` Mark Kettenis
2012-06-06 19:17 ` Tom Tromey
2012-06-02 20:23 ` [PATCH 04/10] Ada language Sergio Durigan Junior
2012-06-13 4:57 ` Sergio Durigan Junior
2012-06-13 14:50 ` Joel Brobecker
2012-06-02 20:23 ` [PATCH 10/10] Go programming language Sergio Durigan Junior
2012-06-13 4:58 ` Sergio Durigan Junior
2012-06-13 17:02 ` Doug Evans
2012-06-02 20:24 ` [PATCH 08/10] Objective-C language Sergio Durigan Junior
2012-06-13 4:59 ` Sergio Durigan Junior
2012-06-13 14:54 ` Joel Brobecker
2012-06-13 16:02 ` Tom Tromey
2012-06-02 20:24 ` [PATCH 05/10] Fortran language Sergio Durigan Junior
2012-06-13 4:59 ` Sergio Durigan Junior
2012-06-13 14:55 ` Joel Brobecker
2012-06-02 20:33 ` [PATCH 09/10] Pascal language Sergio Durigan Junior
2012-06-05 7:39 ` Pierre Muller
2012-06-02 20:33 ` [PATCH 07/10] Modula-2 language Sergio Durigan Junior
2012-06-13 4:59 ` Sergio Durigan Junior
2012-06-13 14:51 ` Joel Brobecker
2012-06-16 14:29 ` Gaius Mulley
2012-06-02 20:34 ` [PATCH 06/10] Java language Sergio Durigan Junior
2012-06-04 20:27 ` Tom Tromey
2012-06-05 0:35 ` Sergio Durigan Junior
2012-06-06 20:02 ` Tom Tromey
2012-06-07 0:57 ` Joel Brobecker
2012-06-04 20:38 ` [PATCH 00/10] Remove `expout*' globals from parser-defs.h Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206042042.q54Kg4mU002330@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox