From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-91766-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17208 invoked by alias); 4 Jun 2012 20:42:30 -0000
Received: (qmail 17193 invoked by uid 22791); 4 Jun 2012 20:42:29 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,TW_YY,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jun 2012 20:42:15 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id q54Kg6j5032179;	Mon, 4 Jun 2012 22:42:06 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id q54Kg4mU002330;	Mon, 4 Jun 2012 22:42:04 +0200 (CEST)
Date: Mon, 04 Jun 2012 20:42:00 -0000
Message-Id: <201206042042.q54Kg4mU002330@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: tromey@redhat.com
CC: sergiodj@redhat.com, gdb-patches@sourceware.org
In-reply-to: <87lik2n7ik.fsf@fleche.redhat.com> (message from Tom Tromey on	Mon, 04 Jun 2012 14:31:47 -0600)
Subject: Re: [PATCH 03/10] C language
References: <1338665528-5932-1-git-send-email-sergiodj@redhat.com>	<1338665528-5932-4-git-send-email-sergiodj@redhat.com> <87lik2n7ik.fsf@fleche.redhat.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-06/txt/msg00099.txt.bz2

> From: Tom Tromey <tromey@redhat.com>
> Date: Mon, 04 Jun 2012 14:31:47 -0600
> 
> Sergio> +#define	yyparse	_c_parse
> 
> It is pedantically better to avoid names with a leading underscore.
> While it probably will never cause any problem in practice, I think it
> is also just as easy to pick pedantically-correct names at the outset.
> 
> So, could you rename these to $LANG_parse_internal or something like that?

I hesitated to bring it up, but when I was looking into using the yacc
-p option to get rid of the #defines, the underscored names posed a
problem.

So if you go through the trouble of renaming things, it might make
sense to use a consistent prefix ($LANG_) and give the wrappers
different names.