From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12041 invoked by alias); 4 Jun 2012 20:39:46 -0000 Received: (qmail 12029 invoked by uid 22791); 4 Jun 2012 20:39:45 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_YY,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jun 2012 20:39:26 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q54KdQq0027831 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 4 Jun 2012 16:39:26 -0400 Received: from psique ([10.3.113.17]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q54KdOge022648; Mon, 4 Jun 2012 16:39:25 -0400 From: Sergio Durigan Junior To: Tom Tromey Cc: GDB Patches Subject: Re: [PATCH 03/10] C language References: <1338665528-5932-1-git-send-email-sergiodj@redhat.com> <1338665528-5932-4-git-send-email-sergiodj@redhat.com> <87lik2n7ik.fsf@fleche.redhat.com> X-URL: http://www.redhat.com Date: Mon, 04 Jun 2012 20:39:00 -0000 In-Reply-To: <87lik2n7ik.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 04 Jun 2012 14:31:47 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00098.txt.bz2 On Monday, June 04 2012, Tom Tromey wrote: > Sergio> +#define yyparse _c_parse > > It is pedantically better to avoid names with a leading underscore. > While it probably will never cause any problem in practice, I think it > is also just as easy to pick pedantically-correct names at the outset. > > So, could you rename these to $LANG_parse_internal or something like > that? Yeah, some languages were already using $LANG_parse_internal. You're right, I will use this pattern instead of _$LANG. > Sergio> - result = yyparse (); > Sergio> + result = _c_parse (); > > I think you don't need to change this line. > > From a spot check it appears these comments apply to all the other yacc > parsers in the series. Ok, I will revert all those changes to `yyparse' instead of `_$LANG'. Thanks, -- Sergio