Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [python][patch] Fix 11036
Date: Fri, 26 Feb 2010 23:16:00 -0000	[thread overview]
Message-ID: <m3d3zrmvuu.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100226123749.GA16942@localhost.localdomain> (Phil Muldoon's 	message of "Fri, 26 Feb 2010 12:37:50 +0000")

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> If you examine the runtime, the return here is a valid value, not
Phil> a NULL.  In any case, I think that if read_var returns NULL, then this
Phil> is an error case.  If anyone knows this to be different let me know and
Phil> I can go back to returning None in this case.  To reflect this, if the
Phil> result of read_var is NULL, I raise an exception.  What do you think?

I think this is fine.
I dug through the code a bit and I also couldn't see when read_var_value
would return NULL.  Perhaps it is from before the LOC_COMPUTED case was
changed to set the "optimized out" flag?  (Just a random hypothesis
based on the documentation for symbol_computed_ops::read_variable.)

This patch is ok.

Tom


  parent reply	other threads:[~2010-02-26 23:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-25 14:29 Phil Muldoon
2010-02-25 18:34 ` Tom Tromey
2010-02-26 12:38   ` Phil Muldoon
2010-02-26 14:56     ` Eli Zaretskii
2010-02-26 23:16     ` Tom Tromey [this message]
2010-02-28 22:06       ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3d3zrmvuu.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox