From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6417 invoked by alias); 26 Feb 2010 23:16:18 -0000 Received: (qmail 6401 invoked by uid 22791); 26 Feb 2010 23:16:17 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Feb 2010 23:16:13 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1QNGBtk025366 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Feb 2010 18:16:11 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1QNGBj8008381; Fri, 26 Feb 2010 18:16:11 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o1QNGAOr009845; Fri, 26 Feb 2010 18:16:10 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id B8F61379956; Fri, 26 Feb 2010 16:16:09 -0700 (MST) From: Tom Tromey To: Phil Muldoon Cc: gdb-patches@sourceware.org Subject: Re: [python][patch] Fix 11036 References: <20100225142823.GA10175@localhost.localdomain> <20100226123749.GA16942@localhost.localdomain> Reply-To: tromey@redhat.com Date: Fri, 26 Feb 2010 23:16:00 -0000 In-Reply-To: <20100226123749.GA16942@localhost.localdomain> (Phil Muldoon's message of "Fri, 26 Feb 2010 12:37:50 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00664.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> If you examine the runtime, the return here is a valid value, not Phil> a NULL. In any case, I think that if read_var returns NULL, then this Phil> is an error case. If anyone knows this to be different let me know and Phil> I can go back to returning None in this case. To reflect this, if the Phil> result of read_var is NULL, I raise an exception. What do you think? I think this is fine. I dug through the code a bit and I also couldn't see when read_var_value would return NULL. Perhaps it is from before the LOC_COMPUTED case was changed to set the "optimized out" flag? (Just a random hypothesis based on the documentation for symbol_computed_ops::read_variable.) This patch is ok. Tom