Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [python][patch] Fix 11036
Date: Fri, 26 Feb 2010 14:56:00 -0000	[thread overview]
Message-ID: <83mxywkpwq.fsf@gnu.org> (raw)
In-Reply-To: <20100226123749.GA16942@localhost.localdomain>

> Date: Fri, 26 Feb 2010 12:37:50 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> Cc: gdb-patches@sourceware.org
> 
> I have also updated the comments and the documentation to reflect the
> new decisions.

Thanks.  I have a couple of comments:

> +@defmethod Frame read_var variable @r{[}block@r{]}
> +Return the value of the given variable in this frame.  If the optional
> +block argument is provided, search for the variable from that current
> +block; otherwise start at the frame's current block (which is

Please use @var for the arguments:

  Return the value of @var{variable} in this frame.  If the optional
  argument @var{block} is provided, search for the variable from that
  block; otherwise start at the frame's current block (which is

(note that I also slightly reworded your text).

Okay with these changes.


  reply	other threads:[~2010-02-26 14:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-25 14:29 Phil Muldoon
2010-02-25 18:34 ` Tom Tromey
2010-02-26 12:38   ` Phil Muldoon
2010-02-26 14:56     ` Eli Zaretskii [this message]
2010-02-26 23:16     ` Tom Tromey
2010-02-28 22:06       ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mxywkpwq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox