Re: PR10179, Add support to set a breakpoint at every function in a file

[Tom Tromey <tromey@redhat.com>]

>>>>> "Chris" == Chris Moller <cmoller@redhat.com> writes:

Chris> +2010-04-20  Chris Moller  <cmoller@redhat.com>
Chris> +	PR filename-filtered rbreak/10179

This particular syntax probably won't have the desired effect.
The commit script only recognizes a few specific formats.
It should be just "PR category/NNNN", like "PR breakpoints/10179".

Chris> +	* symtab.c (rbreak_command): Added code to detect a filename
Chris> +	specification in conjunction with the function specification (in
Chris> +	the form of "filename : regex", checking to make sure that the
Chris> +	colon isn't part of a qualified function name).  If the filename
Chris> +	is discovered, it's passed to search_symbols.

The description is too long.  It should only describe what is changing.
Any further details belong in the code.

Chris> +      char * colon = strchr (regexp, ':');

Extra space after "*".

Chris> +	  int ix;
Chris> +	  char * ta;

I agree with Michael about the names.

Chris> +	  while (isspace (ta[ix])) { ta[ix--] = 0; }

As Michael, this isn't our style.

This requires a documentation and NEWS patch.

Tom