From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2294 invoked by alias); 20 Apr 2010 19:44:18 -0000 Received: (qmail 2282 invoked by uid 22791); 20 Apr 2010 19:44:17 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Apr 2010 19:44:11 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3KJi9TT002966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 Apr 2010 15:44:09 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3KJi9J2009594; Tue, 20 Apr 2010 15:44:09 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3KJi84m003175; Tue, 20 Apr 2010 15:44:08 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id D506A37979C; Tue, 20 Apr 2010 13:44:07 -0600 (MDT) From: Tom Tromey To: Chris Moller Cc: gdb-patches@sourceware.org Subject: Re: PR10179, Add support to set a breakpoint at every function in a file References: <4BCDFEA5.9090501@redhat.com> Reply-To: tromey@redhat.com Date: Tue, 20 Apr 2010 19:44:00 -0000 In-Reply-To: <4BCDFEA5.9090501@redhat.com> (Chris Moller's message of "Tue, 20 Apr 2010 15:21:09 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00639.txt.bz2 >>>>> "Chris" == Chris Moller writes: Chris> +2010-04-20 Chris Moller Chris> + PR filename-filtered rbreak/10179 This particular syntax probably won't have the desired effect. The commit script only recognizes a few specific formats. It should be just "PR category/NNNN", like "PR breakpoints/10179". Chris> + * symtab.c (rbreak_command): Added code to detect a filename Chris> + specification in conjunction with the function specification (in Chris> + the form of "filename : regex", checking to make sure that the Chris> + colon isn't part of a qualified function name). If the filename Chris> + is discovered, it's passed to search_symbols. The description is too long. It should only describe what is changing. Any further details belong in the code. Chris> + char * colon = strchr (regexp, ':'); Extra space after "*". Chris> + int ix; Chris> + char * ta; I agree with Michael about the names. Chris> + while (isspace (ta[ix])) { ta[ix--] = 0; } As Michael, this isn't our style. This requires a documentation and NEWS patch. Tom