From: Chris Moller <cmoller@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: PR10179, Add support to set a breakpoint at every function in a file
Date: Fri, 23 Apr 2010 12:09:00 -0000 [thread overview]
Message-ID: <4BD18E07.9000101@redhat.com> (raw)
In-Reply-To: <83tyr234bw.fsf@gnu.org>
On 04/23/10 05:28, Eli Zaretskii wrote:
>> Date: Tue, 20 Apr 2010 22:56:14 -0400
>> From: Chris Moller<cmoller@redhat.com>
>> CC: gdb-patches@sourceware.org
>>
>> --- NEWS 19 Apr 2010 00:48:43 -0000 1.373
>> +++ NEWS 21 Apr 2010 02:52:34 -0000
>> @@ -47,6 +47,10 @@
>> single `break' command creates multiple breakpoints (e.g.,
>> breakpoints on overloaded c++ functions).
>>
>> +* The `rbreak' command now accepts a filename specification as part of
>> + its argument, limiting the functions selected by the regex to those
>> + in the specified file.
>> +
>>
>
> This part is okay.
>
>
>> + * refcard.tex (Breakpoints and Watchpoints): Added brief
>> + description of ilename-qualified rbreak.
>>
> ^^^^^^^
> A typo.
>
>
>> +@item rbreak @var{filename:regex}
>>
>
> This should separate filename and regex, because they are 2 distinct
> arguments.
>
> @item rbreak @var{filename}:@var{regex}
>
>
>> +If @code{rbreak} is called with a filename qualification, it limits
>> +the search for functions matching the given regular expression to the
>> +specified file. This can be used, for example, to set breakponts on
>> +every function in a given file:
>>
>
> It is a good idea to mention in the text the arguments to the
> command. Like this:
>
> @item rbreak @var{file}:@var{regex}
>
> If @code{rbreak} is called with a filename qualification, it limits
> the search for functions matching the given regular expression to the
> specified @var{file}. This can be used, for example, to set
> breakponts on every function in a given file:
>
> Okay with these changes.
>
Fixed up and committed. Thanks.
> Thanks.
>
prev parent reply other threads:[~2010-04-23 12:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 19:21 Chris Moller
2010-04-20 19:23 ` Michael Snyder
2010-04-20 19:25 ` Chris Moller
2010-04-20 19:27 ` Michael Snyder
2010-04-20 19:30 ` Chris Moller
2010-04-20 19:35 ` Michael Snyder
2010-04-20 19:44 ` Tom Tromey
2010-04-21 2:56 ` Chris Moller
2010-04-21 21:24 ` Michael Snyder
2010-04-21 22:27 ` Tom Tromey
2010-04-23 9:30 ` Eli Zaretskii
2010-04-23 12:09 ` Chris Moller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD18E07.9000101@redhat.com \
--to=cmoller@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox