From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17848 invoked by alias); 23 Apr 2010 12:09:57 -0000 Received: (qmail 17836 invoked by uid 22791); 23 Apr 2010 12:09:56 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Apr 2010 12:09:49 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3NC9ifC030249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 23 Apr 2010 08:09:44 -0400 Received: from qcore.mollernet.net (vpn-10-99.rdu.redhat.com [10.11.10.99]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3NC9ibq015211; Fri, 23 Apr 2010 08:09:44 -0400 Message-ID: <4BD18E07.9000101@redhat.com> Date: Fri, 23 Apr 2010 12:09:00 -0000 From: Chris Moller User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: PR10179, Add support to set a breakpoint at every function in a file References: <4BCDFEA5.9090501@redhat.com> <4BCE694E.9060101@redhat.com> <83tyr234bw.fsf@gnu.org> In-Reply-To: <83tyr234bw.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00785.txt.bz2 On 04/23/10 05:28, Eli Zaretskii wrote: >> Date: Tue, 20 Apr 2010 22:56:14 -0400 >> From: Chris Moller >> CC: gdb-patches@sourceware.org >> >> --- NEWS 19 Apr 2010 00:48:43 -0000 1.373 >> +++ NEWS 21 Apr 2010 02:52:34 -0000 >> @@ -47,6 +47,10 @@ >> single `break' command creates multiple breakpoints (e.g., >> breakpoints on overloaded c++ functions). >> >> +* The `rbreak' command now accepts a filename specification as part of >> + its argument, limiting the functions selected by the regex to those >> + in the specified file. >> + >> > > This part is okay. > > >> + * refcard.tex (Breakpoints and Watchpoints): Added brief >> + description of ilename-qualified rbreak. >> > ^^^^^^^ > A typo. > > >> +@item rbreak @var{filename:regex} >> > > This should separate filename and regex, because they are 2 distinct > arguments. > > @item rbreak @var{filename}:@var{regex} > > >> +If @code{rbreak} is called with a filename qualification, it limits >> +the search for functions matching the given regular expression to the >> +specified file. This can be used, for example, to set breakponts on >> +every function in a given file: >> > > It is a good idea to mention in the text the arguments to the > command. Like this: > > @item rbreak @var{file}:@var{regex} > > If @code{rbreak} is called with a filename qualification, it limits > the search for functions matching the given regular expression to the > specified @var{file}. This can be used, for example, to set > breakponts on every function in a given file: > > Okay with these changes. > Fixed up and committed. Thanks. > Thanks. >