From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [python][patch] Return hash value for gdb.Value.
Date: Thu, 13 May 2010 17:18:00 -0000 [thread overview]
Message-ID: <m3d3wzvicz.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4BEC3039.2060400@redhat.com> (Phil Muldoon's message of "Thu, 13 May 2010 18:00:41 +0100")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> This patch implements the hash function for gdb.Value. It purely
Phil> replicates the function of id() in that it returns the object
Phil> address as the hash value. This allows gdb.Values to be hashable.
Thanks for doing this.
Phil> 2010-05-13 Phil Muldoon <pmuldoon@redhat.com>
Phil> * gdb.python/py-value.exp (test_value_hash): New function.
Mention the PR number here too.
Phil> +long valpy_hash (PyObject *self)
Should be 'static'.
Newline after 'long'.
Ok with those changes.
Tom
prev parent reply other threads:[~2010-05-13 17:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 17:05 Phil Muldoon
2010-05-13 17:18 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3wzvicz.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox