From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72985-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9767 invoked by alias); 13 May 2010 17:09:41 -0000
Received: (qmail 9754 invoked by uid 22791); 13 May 2010 17:09:40 -0000
X-SWARE-Spam-Status: No, hits=-5.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 May 2010 17:09:36 +0000
Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4DH9Yuu011265	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Thu, 13 May 2010 13:09:34 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4DH9Xvm017466;	Thu, 13 May 2010 13:09:33 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o4DH9Wiu003545;	Thu, 13 May 2010 13:09:33 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 611BF37881C; Thu, 13 May 2010 11:09:32 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [python][patch] Return hash value for gdb.Value.
References: <4BEC3039.2060400@redhat.com>
Reply-To: tromey@redhat.com
Date: Thu, 13 May 2010 17:18:00 -0000
In-Reply-To: <4BEC3039.2060400@redhat.com> (Phil Muldoon's message of "Thu, 13	May 2010 18:00:41 +0100")
Message-ID: <m3d3wzvicz.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00278.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> This patch implements the hash function for gdb.Value. It purely
Phil> replicates the function of id() in that it returns the object
Phil> address as the hash value. This allows gdb.Values to be hashable.

Thanks for doing this.

Phil> 2010-05-13  Phil Muldoon  <pmuldoon@redhat.com>

Phil> 	* gdb.python/py-value.exp (test_value_hash): New function.

Mention the PR number here too.

Phil> +long valpy_hash (PyObject *self)

Should be 'static'.
Newline after 'long'.

Ok with those changes.

Tom