Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH] gdb: sim: add command line completion
Date: Thu, 14 Apr 2011 20:02:00 -0000	[thread overview]
Message-ID: <m3d3kofvpt.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1302219156-9055-1-git-send-email-vapier@gentoo.org> (Mike	Frysinger's message of "Thu, 7 Apr 2011 19:32:36 -0400")

>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:

Mike> For now, only the sub-command name is completed.  No support yet for
Mike> completing options to that command.  But even this is a huge step as
Mike> currently, nothing is completed, and the basic "help sim" is fairly
Mike> obtuse as to what exactly the "sim" command accepts.

Thanks for doing this.

Mike> +char **sim_command_completer (struct cmd_list_element *ignore,
Mike> +			      char *text, char *word)

I think this could be static.
And, newline after the initial "char **".

I don't really know anything about sim, but I didn't see anything
obviously bad in there.  So, ok with the above change.

Tom


  reply	other threads:[~2011-04-14 20:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-07 23:32 Mike Frysinger
2011-04-14 20:02 ` Tom Tromey [this message]
2011-04-15  3:44   ` [toolchain-devel] " Mike Frysinger
2011-04-19 17:13     ` Tom Tromey
2011-04-15  3:20 ` [PATCH v2] " Mike Frysinger
2011-04-16 11:40   ` Richard Earnshaw
2011-04-16 18:33     ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3d3kofvpt.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=toolchain-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox