From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2805 invoked by alias); 14 Apr 2011 20:02:18 -0000 Received: (qmail 2795 invoked by uid 22791); 14 Apr 2011 20:02:17 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Apr 2011 20:02:07 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3EK1qnH010564 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 14 Apr 2011 16:01:52 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3EK1qCd010692; Thu, 14 Apr 2011 16:01:52 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3EK1pKg016866; Thu, 14 Apr 2011 16:01:51 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id CE28437831C; Thu, 14 Apr 2011 14:01:50 -0600 (MDT) From: Tom Tromey To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Subject: Re: [PATCH] gdb: sim: add command line completion References: <1302219156-9055-1-git-send-email-vapier@gentoo.org> Date: Thu, 14 Apr 2011 20:02:00 -0000 In-Reply-To: <1302219156-9055-1-git-send-email-vapier@gentoo.org> (Mike Frysinger's message of "Thu, 7 Apr 2011 19:32:36 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00206.txt.bz2 >>>>> "Mike" == Mike Frysinger writes: Mike> For now, only the sub-command name is completed. No support yet for Mike> completing options to that command. But even this is a huge step as Mike> currently, nothing is completed, and the basic "help sim" is fairly Mike> obtuse as to what exactly the "sim" command accepts. Thanks for doing this. Mike> +char **sim_command_completer (struct cmd_list_element *ignore, Mike> + char *text, char *word) I think this could be static. And, newline after the initial "char **". I don't really know anything about sim, but I didn't see anything obviously bad in there. So, ok with the above change. Tom