Re: [toolchain-devel] [PATCH] gdb: sim: add command line completion

[Mike Frysinger <vapier@gentoo.org>]

On Thu, Apr 14, 2011 at 16:01, Tom Tromey wrote:
> Mike Frysinger writes:
>> +char **sim_command_completer (struct cmd_list_element *ignore,
>> +                       char *text, char *word)
>
> I think this could be static.
> And, newline after the initial "char **".

np, updated patch should fix that and one or two other style things.
ive committed that.

> I don't really know anything about sim, but I didn't see anything
> obviously bad in there.  So, ok with the above change.

well, it works for me :)

side note that i meant to ask about earlier, i noticed that i cant
complete things that have a dash in its name.  seems because of
readline having this marked as a word break char (which is
understandable as it is usually used in math expressions).  any way
around this ?

e.g. if i do:
(gdb) sim h<tab>
i get back:
help   hw-board-file   hw-device   hw-file   hw-info   hw-list   hw-trace

and so if i do:
(gdb) sim hw<tab>

it goes to "hw-", but now if i hit <tab>, i get nothing back.  in the
completer, the word is set to "" and the text is "hw-" ...
-mike