From: Tom Tromey <tromey@redhat.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Breakpoint MI notifications
Date: Tue, 26 Apr 2011 20:15:00 -0000 [thread overview]
Message-ID: <m3d3k8rcqx.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201104262235.44963.vladimir@codesourcery.com> (Vladimir Prus's message of "Tue, 26 Apr 2011 22:35:44 +0400")
>>>>> "Volodya" == Vladimir Prus <vladimir@codesourcery.com> writes:
Volodya> Thanks for the review. Is this version better?
The full patch attachment was empty, but I read the delta and have a
couple more nits.
Volodya> +/* Returns 1 iff locations A and B are sufficiently same that
Volodya> + we don't need to report breakpoint as changed. */
Volodya> static int
There's a new rule that there should be a blank line between the comment
and function.
Volodya> + if (strncmp (parse->command, "break-", sizeof ("break-")) == parse->command)
I think the RHS has to be "0". Also, sizeof will include the trailing
\0 here, so you want `sizeof ("break-") - 1'.
Tom
next prev parent reply other threads:[~2011-04-26 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 11:09 Vladimir Prus
2011-04-26 16:04 ` Tom Tromey
2011-04-26 18:36 ` Vladimir Prus
2011-04-26 20:15 ` Tom Tromey [this message]
2011-04-27 21:12 ` [patch] testsuite: unknown output after running [Re: Breakpoint MI notifications] Jan Kratochvil
2011-04-28 5:58 ` Vladimir Prus
2011-04-28 7:32 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3k8rcqx.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox