From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20818 invoked by alias); 26 Apr 2011 20:15:09 -0000 Received: (qmail 20806 invoked by uid 22791); 26 Apr 2011 20:15:05 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Apr 2011 20:14:48 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3QKEl15025204 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 Apr 2011 16:14:48 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p3QKElmi010265; Tue, 26 Apr 2011 16:14:47 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3QKEkcA001297; Tue, 26 Apr 2011 16:14:47 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 8B33B3781C7; Tue, 26 Apr 2011 14:14:46 -0600 (MDT) From: Tom Tromey To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: Breakpoint MI notifications References: <201104261508.20380.vladimir@codesourcery.com> <201104262235.44963.vladimir@codesourcery.com> Date: Tue, 26 Apr 2011 20:15:00 -0000 In-Reply-To: <201104262235.44963.vladimir@codesourcery.com> (Vladimir Prus's message of "Tue, 26 Apr 2011 22:35:44 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00491.txt.bz2 >>>>> "Volodya" == Vladimir Prus writes: Volodya> Thanks for the review. Is this version better? The full patch attachment was empty, but I read the delta and have a couple more nits. Volodya> +/* Returns 1 iff locations A and B are sufficiently same that Volodya> + we don't need to report breakpoint as changed. */ Volodya> static int There's a new rule that there should be a blank line between the comment and function. Volodya> + if (strncmp (parse->command, "break-", sizeof ("break-")) == parse->command) I think the RHS has to be "0". Also, sizeof will include the trailing \0 here, so you want `sizeof ("break-") - 1'. Tom