Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sources.redhat.com
Subject: [patch] testsuite: unknown output after running  [Re: Breakpoint MI notifications]
Date: Wed, 27 Apr 2011 21:12:00 -0000	[thread overview]
Message-ID: <20110427211217.GA24211@host1.jankratochvil.net> (raw)
In-Reply-To: <201104262235.44963.vladimir@codesourcery.com>

On Tue, 26 Apr 2011 20:35:44 +0200, Vladimir Prus wrote:
> On Tuesday, April 26, 2011 20:03:43 Tom Tromey wrote:
> Thanks for the review. Is this version better?

commit ef5d824a73805747d003fed4637c089be2cf2ac1
Author: Vladimir Prus <vladimir@codesourcery.com>
Date:   Wed Apr 27 10:17:33 2011 +0000

        MI breakpoint notifications.
    
[...]

{x86_64,x86_64-m32,i686}-fedora15-linux-gnu:

-XFAIL: gdb.mi/mi-watch.exp: sw: watchpoint trigger (stopped at wrong place)
+XFAIL: gdb.mi/mi-watch.exp: sw: watchpoint trigger (unknown output after running)
-XFAIL: gdb.mi/mi2-watch.exp: sw: watchpoint trigger (stopped at wrong place)
+XFAIL: gdb.mi/mi2-watch.exp: sw: watchpoint trigger (unknown output after running)

Do you find this patch appropriate?  (And if the `$thread_selected_re' part.)

That `stopped at wrong place' happens at all I consider outside of the scope of
this mail thread.


Thanks,
Jan


gdb/testsuite/
2011-04-27  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* lib/mi-support.exp (mi_expect_stop) <stopped at wrong place>: Accept
	thread and breakpoint notifications.

--- a/gdb/testsuite/lib/mi-support.exp
+++ b/gdb/testsuite/lib/mi-support.exp
@@ -1046,7 +1046,7 @@ proc mi_expect_stop { reason func args file line extra test } {
 	    pass "$test"
             return $expect_out(2,string)
 	}
-	-re "\\*stopped,${r}${a}${bn}frame=\{addr=\"$hex\",func=\"$any\",args=\[\\\[\{\]$any\[\\\]\}\],file=\"$any\",fullname=\"${fullname_syntax}$any\",line=\"\[0-9\]*\"\}$after_stopped,thread-id=\"$decimal\",stopped-threads=$any\r\n$prompt_re" {
+	-re "\\*stopped,${r}${a}${bn}frame=\{addr=\"$hex\",func=\"$any\",args=\[\\\[\{\]$any\[\\\]\}\],file=\"$any\",fullname=\"${fullname_syntax}$any\",line=\"\[0-9\]*\"\}$after_stopped,thread-id=\"$decimal\",stopped-threads=$any\r\n($thread_selected_re|$breakpoint_re)*$prompt_re" {
             verbose -log "got $expect_out(buffer)"
 	    fail "$test (stopped at wrong place)"
 	    return -1


  parent reply	other threads:[~2011-04-27 21:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 11:09 Breakpoint MI notifications Vladimir Prus
2011-04-26 16:04 ` Tom Tromey
2011-04-26 18:36   ` Vladimir Prus
2011-04-26 20:15     ` Tom Tromey
2011-04-27 21:12     ` Jan Kratochvil [this message]
2011-04-28  5:58       ` [patch] testsuite: unknown output after running [Re: Breakpoint MI notifications] Vladimir Prus
2011-04-28  7:32         ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110427211217.GA24211@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=tromey@redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox