From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 692 invoked by alias); 27 Apr 2011 21:12:40 -0000 Received: (qmail 684 invoked by uid 22791); 27 Apr 2011 21:12:39 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Apr 2011 21:12:22 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3RLCLiF012097 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 27 Apr 2011 17:12:21 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3RLCJGR018472 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 27 Apr 2011 17:12:21 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p3RLCIFr026219; Wed, 27 Apr 2011 23:12:18 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p3RLCH4U026213; Wed, 27 Apr 2011 23:12:17 +0200 Date: Wed, 27 Apr 2011 21:12:00 -0000 From: Jan Kratochvil To: Vladimir Prus Cc: Tom Tromey , gdb-patches@sources.redhat.com Subject: [patch] testsuite: unknown output after running [Re: Breakpoint MI notifications] Message-ID: <20110427211217.GA24211@host1.jankratochvil.net> References: <201104261508.20380.vladimir@codesourcery.com> <201104262235.44963.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201104262235.44963.vladimir@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00532.txt.bz2 On Tue, 26 Apr 2011 20:35:44 +0200, Vladimir Prus wrote: > On Tuesday, April 26, 2011 20:03:43 Tom Tromey wrote: > Thanks for the review. Is this version better? commit ef5d824a73805747d003fed4637c089be2cf2ac1 Author: Vladimir Prus Date: Wed Apr 27 10:17:33 2011 +0000 MI breakpoint notifications. [...] {x86_64,x86_64-m32,i686}-fedora15-linux-gnu: -XFAIL: gdb.mi/mi-watch.exp: sw: watchpoint trigger (stopped at wrong place) +XFAIL: gdb.mi/mi-watch.exp: sw: watchpoint trigger (unknown output after running) -XFAIL: gdb.mi/mi2-watch.exp: sw: watchpoint trigger (stopped at wrong place) +XFAIL: gdb.mi/mi2-watch.exp: sw: watchpoint trigger (unknown output after running) Do you find this patch appropriate? (And if the `$thread_selected_re' part.) That `stopped at wrong place' happens at all I consider outside of the scope of this mail thread. Thanks, Jan gdb/testsuite/ 2011-04-27 Jan Kratochvil * lib/mi-support.exp (mi_expect_stop) : Accept thread and breakpoint notifications. --- a/gdb/testsuite/lib/mi-support.exp +++ b/gdb/testsuite/lib/mi-support.exp @@ -1046,7 +1046,7 @@ proc mi_expect_stop { reason func args file line extra test } { pass "$test" return $expect_out(2,string) } - -re "\\*stopped,${r}${a}${bn}frame=\{addr=\"$hex\",func=\"$any\",args=\[\\\[\{\]$any\[\\\]\}\],file=\"$any\",fullname=\"${fullname_syntax}$any\",line=\"\[0-9\]*\"\}$after_stopped,thread-id=\"$decimal\",stopped-threads=$any\r\n$prompt_re" { + -re "\\*stopped,${r}${a}${bn}frame=\{addr=\"$hex\",func=\"$any\",args=\[\\\[\{\]$any\[\\\]\}\],file=\"$any\",fullname=\"${fullname_syntax}$any\",line=\"\[0-9\]*\"\}$after_stopped,thread-id=\"$decimal\",stopped-threads=$any\r\n($thread_selected_re|$breakpoint_re)*$prompt_re" { verbose -log "got $expect_out(buffer)" fail "$test (stopped at wrong place)" return -1