From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: "Marcin Kościelnicki" <koriakin@0x04.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdbserver/s390: Add support for compiled agent expressions.
Date: Mon, 14 Mar 2016 16:19:00 -0000 [thread overview]
Message-ID: <m3d1qxxc9t.fsf@oc1027705133.ibm.com> (raw)
In-Reply-To: <1457088067-3197-1-git-send-email-koriakin@0x04.net> ("Marcin \=\?utf-8\?Q\?Ko\=C5\=9Bcielnicki\=22's\?\= message of "Fri, 4 Mar 2016 11:41:07 +0100")
On Fri, Mar 04 2016, Marcin Kościelnicki wrote:
> These sequences assume a z900+ CPU, like the rest of fast tracepoint
> support.
>
> gdb/gdbserver/ChangeLog:
>
> * linux-s390-low.c (add_insns): New function.
> (s390_emit_prologue): New function.
> (s390_emit_epilogue): New function.
> (s390_emit_add): New function.
> (s390_emit_sub): New function.
> (s390_emit_mul): New function.
> (s390_emit_lsh): New function.
> (s390_emit_rsh_signed): New function.
> (s390_emit_rsh_unsigned): New function.
> (s390_emit_ext): New function.
> (s390_emit_log_not): New function.
> (s390_emit_bit_and): New function.
> (s390_emit_bit_or): New function.
> (s390_emit_bit_xor): New function.
> (s390_emit_bit_not): New function.
> (s390_emit_equal): New function.
> (s390_emit_less_signed): New function.
> (s390_emit_less_unsigned): New function.
> (s390_emit_ref): New function.
> (s390_emit_if_goto): New function.
> (s390_emit_goto): New function.
> (s390_write_goto_address): New function.
> (s390_emit_litpool): New function.
> (s390_emit_const): New function.
> (s390_emit_call): New function.
> (s390_emit_reg): New function.
> (s390_emit_pop): New function.
> (s390_emit_stack_flush): New function.
> (s390_emit_zero_ext): New function.
> (s390_emit_swap): New function.
> (s390_emit_stack_adjust): New function.
> (s390_emit_set_r2): New function.
> (s390_emit_int_call_1): New function.
> (s390_emit_void_call_2): New function.
> (s390_emit_eq_goto): New function.
> (s390_emit_ne_goto): New function.
> (s390_emit_lt_goto): New function.
> (s390_emit_le_goto): New function.
> (s390_emit_gt_goto): New function.
> (s390_emit_ge_goto): New function.
> (s390x_emit_prologue): New function.
> (s390x_emit_epilogue): New function.
> (s390x_emit_add): New function.
> (s390x_emit_sub): New function.
> (s390x_emit_mul): New function.
> (s390x_emit_lsh): New function.
> (s390x_emit_rsh_signed): New function.
> (s390x_emit_rsh_unsigned): New function.
> (s390x_emit_ext): New function.
> (s390x_emit_log_not): New function.
> (s390x_emit_bit_and): New function.
> (s390x_emit_bit_or): New function.
> (s390x_emit_bit_xor): New function.
> (s390x_emit_bit_not): New function.
> (s390x_emit_equal): New function.
> (s390x_emit_less_signed): New function.
> (s390x_emit_less_unsigned): New function.
> (s390x_emit_ref): New function.
> (s390x_emit_if_goto): New function.
> (s390x_emit_const): New function.
> (s390x_emit_call): New function.
> (s390x_emit_reg): New function.
> (s390x_emit_pop): New function.
> (s390x_emit_stack_flush): New function.
> (s390x_emit_zero_ext): New function.
> (s390x_emit_swap): New function.
> (s390x_emit_stack_adjust): New function.
> (s390x_emit_int_call_1): New function.
> (s390x_emit_void_call_2): New function.
> (s390x_emit_eq_goto): New function.
> (s390x_emit_ne_goto): New function.
> (s390x_emit_lt_goto): New function.
> (s390x_emit_le_goto): New function.
> (s390x_emit_gt_goto): New function.
> (s390x_emit_ge_goto): New function.
> (s390_emit_ops): New function.
> (struct linux_target_ops): Fill in emit_ops hook.
> ---
> Updated version: deduplicated s390_emit_goto with s390x_emit_goto,
> documentation comments, indent fixes.
This is OK.
One minor nit:
> +static void
> +s390_emit_ext (int arg)
> +{
> + unsigned char buf[] = {
> + 0x8d, 0x20, 0x00, 64-arg, /* sldl %r2, <64-arg> */
> + 0x8e, 0x20, 0x00, 64-arg, /* srda %r2, <64-arg> */
The "-" operator should be separated with spaces from its operands. The
same applies to s390_emit_zero_ext, s390x_emit_ext, and
s390x_emit_zero_ext.
Thanks,
Andreas
next prev parent reply other threads:[~2016-03-14 16:19 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 12:12 [PATCH 0/8] gdb/s390: Add regular and fast tracepoint support Marcin Kościelnicki
2016-01-24 12:12 ` [PATCH 1/8] gdb: Add write_guessed_tracepoint_pc hook to gdbarch Marcin Kościelnicki
2016-01-26 14:58 ` Andreas Arnez
2016-02-07 13:59 ` [PATCH 1/8] gdb: Add supply_pseudo_pc " Marcin Kościelnicki
2016-02-16 18:28 ` Ulrich Weigand
2016-02-16 21:32 ` Marcin Kościelnicki
2016-02-18 10:35 ` [PATCH 1/2] gdb: Add guess_tracepoint_registers " Marcin Kościelnicki
2016-02-18 10:35 ` [PATCH 2/2] gdb/s390: Fill guess_tracepoint_registers hook Marcin Kościelnicki
2016-02-18 16:03 ` Ulrich Weigand
2016-02-18 16:36 ` [PATCH] " Marcin Kościelnicki
2016-02-18 16:48 ` Ulrich Weigand
2016-02-18 16:58 ` Marcin Kościelnicki
2016-02-18 11:38 ` [PATCH 1/2] gdb: Add guess_tracepoint_registers hook to gdbarch Luis Machado
2016-02-18 11:39 ` Marcin Kościelnicki
2016-02-18 11:45 ` [PATCH] " Marcin Kościelnicki
2016-02-18 15:40 ` Ulrich Weigand
2016-02-18 15:41 ` Marcin Kościelnicki
2016-02-18 15:58 ` Ulrich Weigand
2016-02-18 16:01 ` Marcin Kościelnicki
2016-02-18 16:06 ` Ulrich Weigand
2016-02-18 16:11 ` Marcin Kościelnicki
2016-02-18 16:13 ` Ulrich Weigand
2016-02-18 16:22 ` Marcin Kościelnicki
2016-01-24 12:12 ` [PATCH 3/8] gdb/s390: Fill pseudo register agent expression hooks Marcin Kościelnicki
2016-02-07 14:01 ` Marcin Kościelnicki
2016-02-25 19:23 ` Marcin Kościelnicki
2016-03-04 10:42 ` Marcin Kościelnicki
2016-03-11 2:20 ` Marcin Kościelnicki
2016-03-11 9:58 ` Andreas Arnez
2016-03-11 10:04 ` Marcin Kościelnicki
2016-01-24 12:12 ` [PATCH 5/8] gdbserver/s390: Switch on tracepoint support Marcin Kościelnicki
2016-02-07 14:04 ` Marcin Kościelnicki
2016-02-22 7:38 ` [PATCH] " Marcin Kościelnicki
2016-03-04 10:39 ` [PATCH v3] " Marcin Kościelnicki
2016-03-15 18:41 ` [PATCH v4] " Marcin Kościelnicki
2016-03-22 9:16 ` Marcin Kościelnicki
2016-03-23 15:25 ` Andreas Arnez
2016-03-24 1:15 ` Marcin Kościelnicki
2016-03-29 18:31 ` Ulrich Weigand
2016-03-29 21:40 ` Marcin Kościelnicki
2016-03-29 21:40 ` [PATCH obv] gdb/NEWS: Add mention of s390*-linux tracepoints Marcin Kościelnicki
2016-03-30 2:49 ` Eli Zaretskii
2016-01-24 12:12 ` [PATCH 4/8] gdb/s390: Fill gen_return_address hook Marcin Kościelnicki
2016-02-07 14:02 ` Marcin Kościelnicki
2016-02-25 19:23 ` Marcin Kościelnicki
2016-03-04 10:42 ` Marcin Kościelnicki
2016-03-11 11:20 ` Andreas Arnez
2016-03-11 11:35 ` Marcin Kościelnicki
2016-03-11 12:18 ` Andreas Arnez
2016-03-11 12:26 ` Marcin Kościelnicki
2016-03-11 15:31 ` Andreas Arnez
2016-03-11 15:44 ` Pedro Alves
2016-03-11 16:45 ` Andreas Arnez
2016-03-11 17:02 ` Pedro Alves
2016-03-11 18:17 ` Eli Zaretskii
2016-03-11 18:37 ` Pedro Alves
2016-03-11 19:34 ` Eli Zaretskii
2016-03-15 11:11 ` Pedro Alves
2016-03-15 11:23 ` Andreas Arnez
2016-03-15 11:30 ` Pedro Alves
2016-03-11 18:07 ` Eli Zaretskii
2016-03-13 9:53 ` Marcin Kościelnicki
2016-03-14 10:07 ` Andreas Arnez
2016-01-24 12:12 ` [PATCH 8/8] gdbserver/s390: Add support for compiled agent expressions Marcin Kościelnicki
2016-03-04 10:41 ` [PATCH v2] " Marcin Kościelnicki
2016-03-14 16:19 ` Andreas Arnez [this message]
2016-01-24 12:12 ` [PATCH 7/8] gdb.trace: Bump tspeed.exp timeout to 600 seconds Marcin Kościelnicki
2016-01-26 18:17 ` Andreas Arnez
2016-01-29 9:53 ` [PATCH] " Marcin Kościelnicki
2016-02-12 11:20 ` Yao Qi
2016-02-18 18:54 ` Marcin Kościelnicki
2016-01-24 12:12 ` [PATCH 2/8] gdb/s390: Fill write_guessed_tracepoint_pc hook Marcin Kościelnicki
2016-01-26 18:12 ` Andreas Arnez
2016-01-26 19:26 ` Marcin Kościelnicki
2016-01-29 18:57 ` Andreas Arnez
2016-02-07 14:00 ` [PATCH 2/8] gdb/s390: Fill supply_pseudo_pc hook Marcin Kościelnicki
2016-01-24 12:13 ` [PATCH 6/8] gdbserver/s390: Add fast tracepoint support Marcin Kościelnicki
2016-01-25 14:34 ` Antoine Tremblay
2016-02-19 13:41 ` Marcin Kościelnicki
2016-02-19 14:41 ` Antoine Tremblay
2016-03-04 10:40 ` [PATCH v2] " Marcin Kościelnicki
2016-03-14 16:19 ` Andreas Arnez
2016-03-14 16:25 ` Marcin Kościelnicki
2016-01-25 13:27 ` [PATCH 0/8] gdb/s390: Add regular and " Antoine Tremblay
2016-01-25 13:56 ` Pedro Alves
2016-01-25 14:28 ` Marcin Kościelnicki
2016-01-25 15:57 ` Pedro Alves
2016-01-25 16:03 ` Marcin Kościelnicki
2016-02-12 11:04 ` Marcin Kościelnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d1qxxc9t.fsf@oc1027705133.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=koriakin@0x04.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox