From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62539 invoked by alias); 14 Mar 2016 16:19:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62002 invoked by uid 89); 14 Mar 2016 16:19:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=0x00, nit, 64arg, agent X-HELO: e06smtp09.uk.ibm.com Received: from e06smtp09.uk.ibm.com (HELO e06smtp09.uk.ibm.com) (195.75.94.105) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 14 Mar 2016 16:19:49 +0000 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 14 Mar 2016 16:19:45 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp09.uk.ibm.com (192.168.101.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 14 Mar 2016 16:19:44 -0000 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: arnez@linux.vnet.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9BBC32190046 for ; Mon, 14 Mar 2016 16:19:26 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2EGJiNS56098944 for ; Mon, 14 Mar 2016 16:19:44 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2EGJhE2022483 for ; Mon, 14 Mar 2016 10:19:43 -0600 Received: from oc1027705133.ibm.com (dyn-9-152-212-180.boeblingen.de.ibm.com [9.152.212.180]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u2EGJgtc022439 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 14 Mar 2016 10:19:43 -0600 From: Andreas Arnez To: Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdbserver/s390: Add support for compiled agent expressions. References: <1453637529-26972-9-git-send-email-koriakin@0x04.net> <1457088067-3197-1-git-send-email-koriakin@0x04.net> Date: Mon, 14 Mar 2016 16:19:00 -0000 In-Reply-To: <1457088067-3197-1-git-send-email-koriakin@0x04.net> ("Marcin \=\?utf-8\?Q\?Ko\=C5\=9Bcielnicki\=22's\?\= message of "Fri, 4 Mar 2016 11:41:07 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031416-0037-0000-0000-0000061E9C46 X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00215.txt.bz2 On Fri, Mar 04 2016, Marcin Ko=C5=9Bcielnicki wrote: > These sequences assume a z900+ CPU, like the rest of fast tracepoint > support. > > gdb/gdbserver/ChangeLog: > > * linux-s390-low.c (add_insns): New function. > (s390_emit_prologue): New function. > (s390_emit_epilogue): New function. > (s390_emit_add): New function. > (s390_emit_sub): New function. > (s390_emit_mul): New function. > (s390_emit_lsh): New function. > (s390_emit_rsh_signed): New function. > (s390_emit_rsh_unsigned): New function. > (s390_emit_ext): New function. > (s390_emit_log_not): New function. > (s390_emit_bit_and): New function. > (s390_emit_bit_or): New function. > (s390_emit_bit_xor): New function. > (s390_emit_bit_not): New function. > (s390_emit_equal): New function. > (s390_emit_less_signed): New function. > (s390_emit_less_unsigned): New function. > (s390_emit_ref): New function. > (s390_emit_if_goto): New function. > (s390_emit_goto): New function. > (s390_write_goto_address): New function. > (s390_emit_litpool): New function. > (s390_emit_const): New function. > (s390_emit_call): New function. > (s390_emit_reg): New function. > (s390_emit_pop): New function. > (s390_emit_stack_flush): New function. > (s390_emit_zero_ext): New function. > (s390_emit_swap): New function. > (s390_emit_stack_adjust): New function. > (s390_emit_set_r2): New function. > (s390_emit_int_call_1): New function. > (s390_emit_void_call_2): New function. > (s390_emit_eq_goto): New function. > (s390_emit_ne_goto): New function. > (s390_emit_lt_goto): New function. > (s390_emit_le_goto): New function. > (s390_emit_gt_goto): New function. > (s390_emit_ge_goto): New function. > (s390x_emit_prologue): New function. > (s390x_emit_epilogue): New function. > (s390x_emit_add): New function. > (s390x_emit_sub): New function. > (s390x_emit_mul): New function. > (s390x_emit_lsh): New function. > (s390x_emit_rsh_signed): New function. > (s390x_emit_rsh_unsigned): New function. > (s390x_emit_ext): New function. > (s390x_emit_log_not): New function. > (s390x_emit_bit_and): New function. > (s390x_emit_bit_or): New function. > (s390x_emit_bit_xor): New function. > (s390x_emit_bit_not): New function. > (s390x_emit_equal): New function. > (s390x_emit_less_signed): New function. > (s390x_emit_less_unsigned): New function. > (s390x_emit_ref): New function. > (s390x_emit_if_goto): New function. > (s390x_emit_const): New function. > (s390x_emit_call): New function. > (s390x_emit_reg): New function. > (s390x_emit_pop): New function. > (s390x_emit_stack_flush): New function. > (s390x_emit_zero_ext): New function. > (s390x_emit_swap): New function. > (s390x_emit_stack_adjust): New function. > (s390x_emit_int_call_1): New function. > (s390x_emit_void_call_2): New function. > (s390x_emit_eq_goto): New function. > (s390x_emit_ne_goto): New function. > (s390x_emit_lt_goto): New function. > (s390x_emit_le_goto): New function. > (s390x_emit_gt_goto): New function. > (s390x_emit_ge_goto): New function. > (s390_emit_ops): New function. > (struct linux_target_ops): Fill in emit_ops hook. > --- > Updated version: deduplicated s390_emit_goto with s390x_emit_goto, > documentation comments, indent fixes. This is OK. One minor nit: > +static void > +s390_emit_ext (int arg) > +{ > + unsigned char buf[] =3D { > + 0x8d, 0x20, 0x00, 64-arg, /* sldl %r2, <64-arg> */ > + 0x8e, 0x20, 0x00, 64-arg, /* srda %r2, <64-arg> */ The "-" operator should be separated with spaces from its operands. The same applies to s390_emit_zero_ext, s390x_emit_ext, and s390x_emit_zero_ext. Thanks, Andreas