Re: [PATCH 6/8] gdbserver/s390: Add fast tracepoint support.

["Marcin Kościelnicki" <koriakin@0x04.net>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1347 bytes --]

Thanks for your suggestion, but I'm afraid I won't be doing it that way at all.  We're not quite out of the woods yet on multi-tdesc targets: see https://sourceware.org/bugzilla/show_bug.cgi?id=13808 .  This issue basically requires perfectly matched tdesc between gdbserver and IPA on all architectures, so a more generic mechanism is in order.  I think I will just stuff all possible tdescs for a target in an array and pass the tdesc index to IPA via a global variable.

25 sty 2016 3:34 PM Antoine Tremblay <antoine.tremblay@ericsson.com> napisał(a):
>
>
>
> On 01/24/2016 07:12 AM, Marcin Kościelnicki wrote: 
>
> > +void 
> > +initialize_low_tracepoint (void) 
> > +{ 
> > +  unsigned long hwcap = getauxval (AT_HWCAP); 
>
> You might consider also using proc if getauxval is not available ? 
>
> unsigned long hwcap = 0; 
>
> #ifdef HAVE_GETAUXVAL 
>    hwcap = getauxval (AT_HWCAP); 
> #else 
>    unsigned long data[2]; 
>    FILE *f = fopen ("/proc/self/auxv", "r"); 
>
>    if (f == NULL) 
>      return; 
>
>    while (fread (data, sizeof (data), 1, f) > 0) 
>      { 
>       if (data[0] == AT_HWCAP) 
>         { 
>           hwcap = data[1]; 
>           break; 
>         } 
>      } 
>
>    fclose (f); 
>
>
> Regards, 
> Antoine 
>
\x16º&Öéj×!zÊÞ¶êç×o{ÓÙb²Ö«r\x18\x1dn–­r\x17¬