From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19758 invoked by alias); 19 Feb 2016 13:41:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19574 invoked by uid 89); 19 Feb 2016 13:41:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,MISSING_MIMEOLE,RP_MATCHES_RCVD,SPF_PASS autolearn=no version=3.3.2 spammy=hwcap, Hx-languages-length:1333, woods, HX-MSMail-Priority:Normal X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Feb 2016 13:41:42 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 957033FED6; Fri, 19 Feb 2016 14:42:32 +0100 (CET) Received: from [192.0.0.4] (public-gprs363788.centertel.pl [37.47.52.77]) by hogfather.0x04.net (Postfix) with ESMTPSA id 752B3580088; Fri, 19 Feb 2016 14:41:39 +0100 (CET) Date: Fri, 19 Feb 2016 13:41:00 -0000 Subject: Re: [PATCH 6/8] gdbserver/s390: Add fast tracepoint support. Message-ID: <513a68b9-f88d-4c3f-9b19-bf48e26da0cd@email.android.com> X-Android-Message-ID: <513a68b9-f88d-4c3f-9b19-bf48e26da0cd@email.android.com> In-Reply-To: <56A63283.9000404@ericsson.com> From: =?UTF-8?Q?Marcin_Ko=C5=9Bcielnicki?= To: Antoine Tremblay Cc: gdb-patches@sourceware.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00590.txt.bz2 VGhhbmtzIGZvciB5b3VyIHN1Z2dlc3Rpb24sIGJ1dCBJJ20gYWZyYWlkIEkg d29uJ3QgYmUgZG9pbmcgaXQgdGhhdCB3YXkgYXQgYWxsLiAgV2UncmUgbm90 IHF1aXRlIG91dCBvZiB0aGUgd29vZHMgeWV0IG9uIG11bHRpLXRkZXNjIHRh cmdldHM6IHNlZSBodHRwczovL3NvdXJjZXdhcmUub3JnL2J1Z3ppbGxhL3No b3dfYnVnLmNnaT9pZD0xMzgwOCAuICBUaGlzIGlzc3VlIGJhc2ljYWxseSBy ZXF1aXJlcyBwZXJmZWN0bHkgbWF0Y2hlZCB0ZGVzYyBiZXR3ZWVuIGdkYnNl cnZlciBhbmQgSVBBIG9uIGFsbCBhcmNoaXRlY3R1cmVzLCBzbyBhIG1vcmUg Z2VuZXJpYyBtZWNoYW5pc20gaXMgaW4gb3JkZXIuICBJIHRoaW5rIEkgd2ls bCBqdXN0IHN0dWZmIGFsbCBwb3NzaWJsZSB0ZGVzY3MgZm9yIGEgdGFyZ2V0 IGluIGFuIGFycmF5IGFuZCBwYXNzIHRoZSB0ZGVzYyBpbmRleCB0byBJUEEg dmlhIGEgZ2xvYmFsIHZhcmlhYmxlLgoKMjUgc3R5IDIwMTYgMzozNCBQTSBB bnRvaW5lIFRyZW1ibGF5IDxhbnRvaW5lLnRyZW1ibGF5QGVyaWNzc29uLmNv bT4gbmFwaXNhxYIoYSk6Cj4KPgo+Cj4gT24gMDEvMjQvMjAxNiAwNzoxMiBB TSwgTWFyY2luIEtvxZtjaWVsbmlja2kgd3JvdGU6IAo+Cj4gPiArdm9pZCAK PiA+ICtpbml0aWFsaXplX2xvd190cmFjZXBvaW50ICh2b2lkKSAKPiA+ICt7 IAo+ID4gK8KgIHVuc2lnbmVkIGxvbmcgaHdjYXAgPSBnZXRhdXh2YWwgKEFU X0hXQ0FQKTsgCj4KPiBZb3UgbWlnaHQgY29uc2lkZXIgYWxzbyB1c2luZyBw cm9jIGlmIGdldGF1eHZhbCBpcyBub3QgYXZhaWxhYmxlID8gCj4KPiB1bnNp Z25lZCBsb25nIGh3Y2FwID0gMDsgCj4KPiAjaWZkZWYgSEFWRV9HRVRBVVhW QUwgCj4gwqDCoCBod2NhcCA9IGdldGF1eHZhbCAoQVRfSFdDQVApOyAKPiAj ZWxzZSAKPiDCoMKgIHVuc2lnbmVkIGxvbmcgZGF0YVsyXTsgCj4gwqDCoCBG SUxFICpmID0gZm9wZW4gKCIvcHJvYy9zZWxmL2F1eHYiLCAiciIpOyAKPgo+ IMKgwqAgaWYgKGYgPT0gTlVMTCkgCj4gwqDCoMKgwqAgcmV0dXJuOyAKPgo+ IMKgwqAgd2hpbGUgKGZyZWFkIChkYXRhLCBzaXplb2YgKGRhdGEpLCAxLCBm KSA+IDApIAo+IMKgwqDCoMKgIHsgCj4gwqDCoMKgwqDCoCBpZiAoZGF0YVsw XSA9PSBBVF9IV0NBUCkgCj4gwqDCoMKgwqDCoMKgwqAgeyAKPiDCoMKgwqDC oMKgwqDCoMKgwqAgaHdjYXAgPSBkYXRhWzFdOyAKPiDCoMKgwqDCoMKgwqDC oMKgwqAgYnJlYWs7IAo+IMKgwqDCoMKgwqDCoMKgIH0gCj4gwqDCoMKgwqAg fSAKPgo+IMKgwqAgZmNsb3NlIChmKTsgCj4KPgo+IFJlZ2FyZHMsIAo+IEFu dG9pbmUgCj4K >From gdb-patches-return-129709-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Feb 19 14:36:52 2016 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 107187 invoked by alias); 19 Feb 2016 14:36:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 106411 invoked by uid 89); 19 Feb 2016 14:36:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=syscalls, 1207, sk:syscall, sk:disp-st X-HELO: mail-pf0-f174.google.com Received: from mail-pf0-f174.google.com (HELO mail-pf0-f174.google.com) (209.85.192.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 19 Feb 2016 14:36:43 +0000 Received: by mail-pf0-f174.google.com with SMTP id x65so52164060pfb.1 for ; Fri, 19 Feb 2016 06:36:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=1UhIVRb3FbUIzEcVG/+y57yY9IzztvGPDhCgBriYoBM=; b=PbvPkAgNYYd9l171LbUouOFmLQ61zL+anBU4BNL8G6zLw/ZcpHfHIU7+OPd25tCw2C KG7zyjj7F7QYkBD0zWR9XPn7OPydgPeIUqqA4Y4FRU4t5KbfTH0CfJTd46uNkj8jQ5aX 4FIxpTeISQbAv74dv4vd9ZooAeDhlLOtjSldZGo4K9HHhx1VFvIydzgYLxZCeIYDuHdI dTao96jS/Jmk2dGnT7MnwvPsAGYAGM8BkbWA3YSjC4PXu1PHte8rQX1IFF0cwTPcZDtx lVIN4/AbAcU11w2pmNe0XVfKtbLcIiJWN1Aqon51Ep2zPkTMLfTFlRyB9dOamtzpkVy8 itcw== X-Gm-Message-State: AG10YOSM1gZTmKqllSg+Xg+tqP/lYR1t35rtUVdcJiz1bDoiBikF4Yg+onbdvtesRF7tPg== X-Received: by 10.98.87.142 with SMTP id i14mr18308948pfj.63.1455892602185; Fri, 19 Feb 2016 06:36:42 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id kq3sm18452546pab.24.2016.02.19.06.36.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 19 Feb 2016 06:36:41 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH 2/8] Refactor gdb.base/disp-step-syscall.exp for general step over test Date: Fri, 19 Feb 2016 14:36:00 -0000 Message-Id: <1455892594-2294-3-git-send-email-yao.qi@linaro.org> In-Reply-To: <1455892594-2294-1-git-send-email-yao.qi@linaro.org> References: <1455892594-2294-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00592.txt.bz2 Content-length: 2382 This patch moves some code out of disp_step_cross_syscall to a new proc check_pc_after_cross_syscall, and delete the breakpoint later. gdb/testsuite: 2016-02-19 Yao Qi * gdb.base/disp-step-syscall.exp (check_pc_after_cross_syscall): New proc. (disp_step_cross_syscall): Move code to check_pc_after_cross_syscall and delete breakpoint later. --- gdb/testsuite/gdb.base/disp-step-syscall.exp | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/gdb/testsuite/gdb.base/disp-step-syscall.exp b/gdb/testsuite/gdb.base/disp-step-syscall.exp index 80cdc3b..aba5db8 100644 --- a/gdb/testsuite/gdb.base/disp-step-syscall.exp +++ b/gdb/testsuite/gdb.base/disp-step-syscall.exp @@ -32,6 +32,18 @@ if { [istarget "i\[34567\]86-*-linux*"] || [istarget "x86_64-*-linux*"] } { return -1 } +proc check_pc_after_cross_syscall { syscall syscall_insn_next_addr } { + set syscall_insn_next_addr_found [get_hexadecimal_valueof "\$pc" "0"] + + set test "single step over $syscall final pc" + if {$syscall_insn_next_addr != 0 + && $syscall_insn_next_addr == $syscall_insn_next_addr_found} { + pass $test + } else { + fail $test + } +} + proc disp_step_cross_syscall { syscall } { with_test_prefix "$syscall" { global syscall_insn @@ -120,7 +132,6 @@ proc disp_step_cross_syscall { syscall } { pass "break on syscall insns" } } - gdb_test_no_output "delete $syscall_bp" "delete break $syscall" gdb_test "continue" "Continuing\\..*Breakpoint \[0-9\]+, .*" \ "continue to syscall insn $syscall" @@ -132,19 +143,13 @@ proc disp_step_cross_syscall { syscall } { return -1 } - set syscall_insn_next_addr_found [get_hexadecimal_valueof "\$pc" "0"] - - set test "single step over $syscall final pc" - if {$syscall_insn_next_addr != 0 - && $syscall_insn_next_addr == $syscall_insn_next_addr_found} { - pass $test - } else { - fail $test - } + check_pc_after_cross_syscall $syscall $syscall_insn_next_addr # Delete breakpoint syscall insns to avoid interference to other syscalls. gdb_test_no_output "delete $syscall_insn_bp" "delete break $syscall insn" + gdb_test_no_output "delete $syscall_bp" "delete break $syscall" + gdb_test "continue" "Continuing\\..*Breakpoint \[0-9\]+, marker \\(\\) at.*" \ "continue to marker ($syscall)" } -- 1.9.1