Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Daniel Jacobowitz <drow@false.org>,
	 deuling@de.ibm.com, 	  gdb-patches@sourceware.org,
	 uweigand@de.ibm.com
Subject: Re: [rfc] Replace macros by gdbarch functions in gdbint manual
Date: Thu, 28 Jun 2007 21:01:00 -0000	[thread overview]
Message-ID: <m3bqf0eyar.fsf@codesourcery.com> (raw)
In-Reply-To: <uzm2kn5a5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 28 Jun 2007 06:09:54 +0300")


Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Wed, 27 Jun 2007 16:11:34 -0400
>> From: Daniel Jacobowitz <drow@false.org>
>> Cc: Markus Deuling <deuling@de.ibm.com>, gdb-patches@sourceware.org, 	uweigand@de.ibm.com
>> 
>> On Wed, Jun 27, 2007 at 09:30:19PM +0300, Eli Zaretskii wrote:
>> > > +the inferior function onto the stack.  In addition to pushing @var{nargs}, the
>> > > +code should push @var{struct_addr} (when @var{struct_return}), and the return
>> >                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^
>> > It looks like something is missing in the parens.  The old text also
>> > had this problem; can someone suggest or guess what was meant here?
>> 
>> It's unclear wording, but I understand it; struct_return is
>> essentially a boolean condition here.  And there's a flag variable of
>> the same name in call_function_by_hand.
>
> So it should say "when @var{struct_return} is non-zero", right?
>
> Or maybe, since you say this is the name of an actual variable, use
> @code{struct_return} instead of @var?

It's an argument to the function, and our convention is to use @var
for those, right?


  parent reply	other threads:[~2007-06-28 18:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-20 10:19 Markus Deuling
2007-06-20 18:32 ` Eli Zaretskii
2007-06-22  7:10   ` Markus Deuling
2007-06-23  8:05     ` Eli Zaretskii
2007-06-23 12:29       ` Daniel Jacobowitz
2007-06-26 17:36       ` Markus Deuling
2007-06-27 18:35         ` Eli Zaretskii
2007-06-28  3:10           ` Daniel Jacobowitz
2007-06-28  4:53             ` Eli Zaretskii
2007-06-28 10:46               ` Markus Deuling
2007-06-29 18:33                 ` Eli Zaretskii
2007-06-28 21:01               ` Jim Blandy [this message]
2007-06-29 17:46                 ` Eli Zaretskii
     [not found] <4688B47B.1000301@de.ibm.com>
2007-07-03 12:23 ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3bqf0eyar.fsf@codesourcery.com \
    --to=jimb@codesourcery.com \
    --cc=deuling@de.ibm.com \
    --cc=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox