From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-49620-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20744 invoked by alias); 28 Jun 2007 18:20:20 -0000
Received: (qmail 20731 invoked by uid 22791); 28 Jun 2007 18:20:19 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 28 Jun 2007 18:20:15 +0000
Received: (qmail 8620 invoked from network); 28 Jun 2007 18:20:13 -0000
Received: from unknown (HELO localhost) (jimb@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 28 Jun 2007 18:20:13 -0000
To: Eli Zaretskii <eliz@gnu.org>
Cc: Daniel Jacobowitz <drow@false.org>,  deuling@de.ibm.com, 	  gdb-patches@sourceware.org,  uweigand@de.ibm.com
Subject: Re: [rfc] Replace macros by gdbarch functions in gdbint manual
References: <4678FEBE.7040209@de.ibm.com> <u7ipyqxxz.fsf@gnu.org> 	<467B7557.9000708@de.ibm.com> <uodj7p04s.fsf@gnu.org> 	<4681382D.1070708@de.ibm.com> <u1wfxntc4.fsf@gnu.org> 	<20070627201134.GA8087@caradoc.them.org> <uzm2kn5a5.fsf@gnu.org>
From: Jim Blandy <jimb@codesourcery.com>
Date: Thu, 28 Jun 2007 21:01:00 -0000
In-Reply-To: <uzm2kn5a5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 28 Jun 2007 06:09:54 +0300")
Message-ID: <m3bqf0eyar.fsf@codesourcery.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-06/txt/msg00493.txt.bz2


Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Wed, 27 Jun 2007 16:11:34 -0400
>> From: Daniel Jacobowitz <drow@false.org>
>> Cc: Markus Deuling <deuling@de.ibm.com>, gdb-patches@sourceware.org, 	uweigand@de.ibm.com
>> 
>> On Wed, Jun 27, 2007 at 09:30:19PM +0300, Eli Zaretskii wrote:
>> > > +the inferior function onto the stack.  In addition to pushing @var{nargs}, the
>> > > +code should push @var{struct_addr} (when @var{struct_return}), and the return
>> >                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^
>> > It looks like something is missing in the parens.  The old text also
>> > had this problem; can someone suggest or guess what was meant here?
>> 
>> It's unclear wording, but I understand it; struct_return is
>> essentially a boolean condition here.  And there's a flag variable of
>> the same name in call_function_by_hand.
>
> So it should say "when @var{struct_return} is non-zero", right?
>
> Or maybe, since you say this is the name of an actual variable, use
> @code{struct_return} instead of @var?

It's an argument to the function, and our convention is to use @var
for those, right?