Re: [rfc] Replace macros by gdbarch functions in gdbint manual

[Eli Zaretskii <eliz@gnu.org>]

> Date: Tue, 26 Jun 2007 18:00:45 +0200
> From: Markus Deuling <deuling@de.ibm.com>
> CC: gdb-patches@sourceware.org, uweigand@de.ibm.com
> 
> again thank you very much for your time.

And thank _you_ for working on this in the first place.

> Is this ok to commit?

Yes, but:

> -and to reflect that in the @code{REGISTER_NAME} and related macros.
> +nd to reflect that in the @code{gdbarch_register_name} and related functions.
   ^^
"and"

> +address of the instruction.  gdbarch_addr_bits_remove would then for example

Please gibe gdbarch_addr_bits_remove a @code markup.

> +@findex gdbarch_ps_regnum
> +If defined, this function returns is the number of the processor status
                                     ^^
The "is" part should be removed.

> +the inferior function onto the stack.  In addition to pushing @var{nargs}, the
> +code should push @var{struct_addr} (when @var{struct_return}), and the return
                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
It looks like something is missing in the parens.  The old text also
had this problem; can someone suggest or guess what was meant here?

Other than that, the patch can go in.