Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Phil Muldoon <pmuldoon@redhat.com>
Subject: Re: [patch] Implement post_event for Python scripts.
Date: Wed, 18 Aug 2010 18:13:00 -0000	[thread overview]
Message-ID: <m3aaojbxh2.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201008181445.52900.pedro@codesourcery.com> (Pedro Alves's	message of "Wed, 18 Aug 2010 14:45:52 +0100")

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> It was brought to my attention that this unfortunatly breaks
Pedro> Windows builds:

Oops, sorry about that.

Pedro> The expedient way to fix this I guess would be to resurrect gdb_pipe
Pedro> from that patch, so that we have a consistent way across hosts
Pedro> to create a pipe.  

Pedro> I do agree that using pipes on common code to wake up the event loop
Pedro> is tackling at the wrong level (we should have an abstracted way to
Pedro> do this, using pipes on posix hosts, events on Windows, etc.), but,
Pedro> I'm happy with a simpler way for now.

Any way is ok by me, but the existing event code in mingw-hdep.c looks
pretty simple too.  I don't understand all of it, but I could try to
make a patch taking this direction if you want.  Just let me know.

Tom


  parent reply	other threads:[~2010-08-18 18:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-20 18:53 Phil Muldoon
2010-07-20 19:08 ` Tom Tromey
2010-07-27 16:30 ` Joel Brobecker
2010-07-28 14:18   ` Phil Muldoon
2010-07-28 17:31     ` Joel Brobecker
2010-07-30 21:43       ` Tom Tromey
2010-08-03 14:26         ` Phil Muldoon
2010-08-03 17:00           ` Eli Zaretskii
2010-08-11 18:35           ` Tom Tromey
2010-08-11 19:05             ` Joel Brobecker
2010-08-11 21:08             ` Phil Muldoon
2010-07-28 17:49     ` Eli Zaretskii
2010-08-18 13:46 ` Pedro Alves
2010-08-18 14:36   ` Daniel Jacobowitz
2010-08-18 17:39     ` Pedro Alves
2010-08-18 18:13   ` Tom Tromey [this message]
2010-08-20  0:35     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3aaojbxh2.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox