From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch] Implement post_event for Python scripts.
Date: Tue, 20 Jul 2010 19:08:00 -0000 [thread overview]
Message-ID: <m3630aas44.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4C45F0B0.5000903@redhat.com> (Phil Muldoon's message of "Tue, 20 Jul 2010 19:53:36 +0100")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> + /* Ignore errors. */
Phil> + PyObject_CallObject (item->event, NULL);
I think this has to explicitly clear the error, like:
if (PyObject_CallObject (item->event, NULL) == NULL)
PyErr_Clear ();
The code parts are ok with this fix.
Tom
next prev parent reply other threads:[~2010-07-20 19:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 18:53 Phil Muldoon
2010-07-20 19:08 ` Tom Tromey [this message]
2010-07-27 16:30 ` Joel Brobecker
2010-07-28 14:18 ` Phil Muldoon
2010-07-28 17:31 ` Joel Brobecker
2010-07-30 21:43 ` Tom Tromey
2010-08-03 14:26 ` Phil Muldoon
2010-08-03 17:00 ` Eli Zaretskii
2010-08-11 18:35 ` Tom Tromey
2010-08-11 19:05 ` Joel Brobecker
2010-08-11 21:08 ` Phil Muldoon
2010-07-28 17:49 ` Eli Zaretskii
2010-08-18 13:46 ` Pedro Alves
2010-08-18 14:36 ` Daniel Jacobowitz
2010-08-18 17:39 ` Pedro Alves
2010-08-18 18:13 ` Tom Tromey
2010-08-20 0:35 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3630aas44.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox