From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74421-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28894 invoked by alias); 20 Jul 2010 19:08:37 -0000
Received: (qmail 28869 invoked by uid 22791); 20 Jul 2010 19:08:36 -0000
X-SWARE-Spam-Status: No, hits=-6.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Jul 2010 19:08:32 +0000
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6KJ8UoR013887	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 20 Jul 2010 15:08:31 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6KJ8Ub4011099;	Tue, 20 Jul 2010 15:08:30 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o6KJ8T76029786;	Tue, 20 Jul 2010 15:08:29 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 3A1E73797EE; Tue, 20 Jul 2010 13:08:28 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch] Implement post_event for Python scripts.
References: <4C45F0B0.5000903@redhat.com>
Date: Tue, 20 Jul 2010 19:08:00 -0000
In-Reply-To: <4C45F0B0.5000903@redhat.com> (Phil Muldoon's message of "Tue, 20	Jul 2010 19:53:36 +0100")
Message-ID: <m3630aas44.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00312.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> +      /* Ignore errors.  */
Phil> +      PyObject_CallObject (item->event, NULL);

I think this has to explicitly clear the error, like:

if (PyObject_CallObject (item->event, NULL) == NULL)
  PyErr_Clear ();

The code parts are ok with this fix.

Tom