Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: Yao Qi <yao@codesourcery.com>,
	Joel Brobecker <brobecker@adacore.com>,
	       gdb-patches@sourceware.org
Subject: Re: [patch] Remove HAVE_UINTPTR_T from gdb_thread_db.h
Date: Fri, 27 May 2011 18:45:00 -0000	[thread overview]
Message-ID: <m3aae8ugnf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1306431533.2008.18.camel@hactar> (Thiago Jung Bauermann's	message of "Thu, 26 May 2011 14:38:53 -0300")

>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:

Thiago> I'm not familiar with gdbserver but would it make sense to make
Thiago> gdbserver internally use the target_ops vector? That would make GDB's
Thiago> -nat.c files usable without modification in gdbserver. Then it would be
Thiago> a matter of porting the gdbserver's additional features which GDB native
Thiago> doesn't have.

The idea makes sense; I think it is among those discussed in previous
threads on this topic.

The devil is in the details.  The *-nat.c files are free to use any
other facility provided by gdb.  So, perhaps this approach would bloat
gdbserver excessively.

At least, I believe that is the standard objection.  I have not
investigated the problem myself.  My view is somewhat more meta: I think
merging the two makes sense, just to avoid the "double patch" problem,
and an important quality is the maintainability of the result; but the
exact path to get there I think it up to whoever does the work.

On this basis, I think Yao's approach, as communicated on the wiki,
seems reasonable.

Tom


  reply	other threads:[~2011-05-27 18:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-14  6:22 Yao Qi
2011-05-14 17:07 ` Joel Brobecker
2011-05-16  5:41   ` Yao Qi
2011-05-26 17:39     ` Thiago Jung Bauermann
2011-05-27 18:45       ` Tom Tromey [this message]
2011-05-30 15:55         ` Joel Brobecker
2011-05-26  8:10   ` [committed] " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3aae8ugnf.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=bauerman@br.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox