From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6836 invoked by alias); 27 May 2011 18:45:55 -0000 Received: (qmail 6825 invoked by uid 22791); 27 May 2011 18:45:55 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 May 2011 18:45:39 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4RIjBuY007144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 27 May 2011 14:45:11 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p4RIjAhS024541; Fri, 27 May 2011 14:45:10 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4RIj8Zx014114; Fri, 27 May 2011 14:45:09 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id B678A3781BA; Fri, 27 May 2011 12:45:08 -0600 (MDT) From: Tom Tromey To: Thiago Jung Bauermann Cc: Yao Qi , Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [patch] Remove HAVE_UINTPTR_T from gdb_thread_db.h References: <4DCE1F43.1000301@codesourcery.com> <20110514170722.GD19356@adacore.com> <4DD0B8D8.9060004@codesourcery.com> <1306431533.2008.18.camel@hactar> Date: Fri, 27 May 2011 18:45:00 -0000 In-Reply-To: <1306431533.2008.18.camel@hactar> (Thiago Jung Bauermann's message of "Thu, 26 May 2011 14:38:53 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00655.txt.bz2 >>>>> "Thiago" == Thiago Jung Bauermann writes: Thiago> I'm not familiar with gdbserver but would it make sense to make Thiago> gdbserver internally use the target_ops vector? That would make GDB's Thiago> -nat.c files usable without modification in gdbserver. Then it would be Thiago> a matter of porting the gdbserver's additional features which GDB native Thiago> doesn't have. The idea makes sense; I think it is among those discussed in previous threads on this topic. The devil is in the details. The *-nat.c files are free to use any other facility provided by gdb. So, perhaps this approach would bloat gdbserver excessively. At least, I believe that is the standard objection. I have not investigated the problem myself. My view is somewhat more meta: I think merging the two makes sense, just to avoid the "double patch" problem, and an important quality is the maintainability of the result; but the exact path to get there I think it up to whoever does the work. On this basis, I think Yao's approach, as communicated on the wiki, seems reasonable. Tom