Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: [patch] Remove HAVE_UINTPTR_T from gdb_thread_db.h
Date: Sat, 14 May 2011 06:22:00 -0000	[thread overview]
Message-ID: <4DCE1F43.1000301@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

When I am trying to move gdb_thread_db.h to common/ dir, I find there is
still a macro check like,

#ifndef HAVE_UINTPTR_T
...
#endif

I don't think we need this any more.  This piece of code was introduced
by patch [1] in 2003, however, in 2008, Daniel has a patch [2] to remove
tests for uintptr_t.

OK to remove this check?

[1] [rfa] gdb_thread_db.h: #errror if no uintptr_t.
http://sourceware.org/ml/gdb-patches/2003-02/msg00708.html
[2] [RFC] Use gnulib's stdint.h.
http://sourceware.org/ml/gdb-patches/2008-06/msg00478.html

-- 
Yao (齐尧)

[-- Attachment #2: remove_HAVE_UINTPTR_T.patch --]
[-- Type: text/x-patch, Size: 759 bytes --]

2011-05-14  Yao Qi  <yao@codesourcery.com>

	* gdb/gdb_thread_db.h: Remove HAVE_UINTPTR_T.

diff --git a/gdb/gdb_thread_db.h b/gdb/gdb_thread_db.h
index e20b415..c770b0c 100644
--- a/gdb/gdb_thread_db.h
+++ b/gdb/gdb_thread_db.h
@@ -203,16 +203,6 @@ typedef struct td_notify
   } u;
 } td_notify_t;
 
-/* Some people still have libc5 or old glibc with no uintptr_t.
-   They lose.  glibc 2.1.3 was released on 2000-02-25, and it has
-   uintptr_t, so it's reasonable to force these people to upgrade.  */
-
-#ifndef HAVE_UINTPTR_T
-#error No uintptr_t available; your C library is too old.
-/* Inhibit further compilation errors after this error.  */
-#define uintptr_t void *
-#endif
-
 /* Structure used to report event.  */
 typedef struct td_event_msg
 {

             reply	other threads:[~2011-05-14  6:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-14  6:22 Yao Qi [this message]
2011-05-14 17:07 ` Joel Brobecker
2011-05-16  5:41   ` Yao Qi
2011-05-26 17:39     ` Thiago Jung Bauermann
2011-05-27 18:45       ` Tom Tromey
2011-05-30 15:55         ` Joel Brobecker
2011-05-26  8:10   ` [committed] " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DCE1F43.1000301@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox