From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30694 invoked by alias); 14 May 2011 06:22:14 -0000 Received: (qmail 30685 invoked by uid 22791); 14 May 2011 06:22:13 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 14 May 2011 06:21:59 +0000 Received: (qmail 28395 invoked from network); 14 May 2011 06:21:58 -0000 Received: from unknown (HELO ?192.168.0.102?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 May 2011 06:21:58 -0000 Message-ID: <4DCE1F43.1000301@codesourcery.com> Date: Sat, 14 May 2011 06:22:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: [patch] Remove HAVE_UINTPTR_T from gdb_thread_db.h Content-Type: multipart/mixed; boundary="------------040305020504000405000202" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00337.txt.bz2 This is a multi-part message in MIME format. --------------040305020504000405000202 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-length: 549 When I am trying to move gdb_thread_db.h to common/ dir, I find there is still a macro check like, #ifndef HAVE_UINTPTR_T ... #endif I don't think we need this any more. This piece of code was introduced by patch [1] in 2003, however, in 2008, Daniel has a patch [2] to remove tests for uintptr_t. OK to remove this check? [1] [rfa] gdb_thread_db.h: #errror if no uintptr_t. http://sourceware.org/ml/gdb-patches/2003-02/msg00708.html [2] [RFC] Use gnulib's stdint.h. http://sourceware.org/ml/gdb-patches/2008-06/msg00478.html -- Yao (齐尧) --------------040305020504000405000202 Content-Type: text/x-patch; name="remove_HAVE_UINTPTR_T.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="remove_HAVE_UINTPTR_T.patch" Content-length: 759 2011-05-14 Yao Qi * gdb/gdb_thread_db.h: Remove HAVE_UINTPTR_T. diff --git a/gdb/gdb_thread_db.h b/gdb/gdb_thread_db.h index e20b415..c770b0c 100644 --- a/gdb/gdb_thread_db.h +++ b/gdb/gdb_thread_db.h @@ -203,16 +203,6 @@ typedef struct td_notify } u; } td_notify_t; -/* Some people still have libc5 or old glibc with no uintptr_t. - They lose. glibc 2.1.3 was released on 2000-02-25, and it has - uintptr_t, so it's reasonable to force these people to upgrade. */ - -#ifndef HAVE_UINTPTR_T -#error No uintptr_t available; your C library is too old. -/* Inhibit further compilation errors after this error. */ -#define uintptr_t void * -#endif - /* Structure used to report event. */ typedef struct td_event_msg { --------------040305020504000405000202--