From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <alves.ped@gmail.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
Stan Shebs <stanshebs@earthlink.net>,
gdb-patches@sourceware.org
Subject: Re: commands.h and cli/cli-decode.h dups
Date: Tue, 03 Jan 2012 14:57:00 -0000 [thread overview]
Message-ID: <m3aa64hm28.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4F0300C0.8040004@gmail.com> (Pedro Alves's message of "Tue, 03 Jan 2012 13:21:04 +0000")
>>>>> "Pedro" == Pedro Alves <alves.ped@gmail.com> writes:
Pedro> So this patch does the next step after Andrew's changes.
Pedro> It eliminates the declaration duplication, by removing
Pedro> the "public" declarations from cli-decode.h, and the private
Pedro> interfaces from command.h. There are perhaps functions that
Pedro> are "public" today that shouldn't, but we can move the
Pedro> declarations then if we fix the uses.
Pedro> It then also adds a couple of comments to the headers to
Pedro> indicate their purposes.
Pedro> Comments?
I am totally in favor of it.
I think duplication of this sort is a "worst practice".
Tom
next prev parent reply other threads:[~2012-01-03 14:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 4:44 FYI: minsyms documentation Tom Tromey
2011-12-22 5:17 ` Joel Brobecker
2011-12-22 20:13 ` Stan Shebs
2011-12-22 20:21 ` Tom Tromey
2011-12-22 21:06 ` Eli Zaretskii
2011-12-23 4:21 ` Stan Shebs
2011-12-23 16:01 ` Eli Zaretskii
2012-01-02 22:08 ` Tom Tromey
2012-01-03 8:17 ` Eli Zaretskii
2011-12-24 7:45 ` Yao Qi
2011-12-24 13:21 ` Eli Zaretskii
2012-01-02 22:08 ` Tom Tromey
2012-01-03 8:18 ` Eli Zaretskii
2011-12-22 21:18 ` Stan Shebs
2011-12-23 10:38 ` Joel Brobecker
2012-01-02 22:14 ` Tom Tromey
2012-01-03 2:53 ` Joel Brobecker
2012-01-03 11:05 ` Pedro Alves
2012-01-03 13:21 ` commands.h and cli/cli-decode.h dups (was: Re: FYI: minsyms documentation) Pedro Alves
2012-01-03 14:57 ` Tom Tromey [this message]
2012-01-03 17:11 ` commands.h and cli/cli-decode.h dups Joel Brobecker
2012-01-05 11:40 ` Pedro Alves
2012-01-03 11:18 ` FYI: minsyms documentation Pedro Alves
2012-01-15 18:49 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aa64hm28.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=alves.ped@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=stanshebs@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox