From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22140 invoked by alias); 3 Jan 2012 14:57:06 -0000 Received: (qmail 22130 invoked by uid 22791); 3 Jan 2012 14:57:06 -0000 X-SWARE-Spam-Status: No, hits=-7.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Jan 2012 14:56:52 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q03EuKwH032131 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 3 Jan 2012 09:56:20 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q03EuKs9005944; Tue, 3 Jan 2012 09:56:20 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q03EuFTw020250; Tue, 3 Jan 2012 09:56:16 -0500 From: Tom Tromey To: Pedro Alves Cc: Joel Brobecker , Stan Shebs , gdb-patches@sourceware.org Subject: Re: commands.h and cli/cli-decode.h dups References: <4EF38DAD.3040106@earthlink.net> <20111223042053.GW23376@adacore.com> <20120103025256.GD2730@adacore.com> <4F02E0CC.5020408@gmail.com> <4F0300C0.8040004@gmail.com> Date: Tue, 03 Jan 2012 14:57:00 -0000 In-Reply-To: <4F0300C0.8040004@gmail.com> (Pedro Alves's message of "Tue, 03 Jan 2012 13:21:04 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00094.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> So this patch does the next step after Andrew's changes. Pedro> It eliminates the declaration duplication, by removing Pedro> the "public" declarations from cli-decode.h, and the private Pedro> interfaces from command.h. There are perhaps functions that Pedro> are "public" today that shouldn't, but we can move the Pedro> declarations then if we fix the uses. Pedro> It then also adds a couple of comments to the headers to Pedro> indicate their purposes. Pedro> Comments? I am totally in favor of it. I think duplication of this sort is a "worst practice". Tom