Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Stan Shebs <stanshebs@earthlink.net>
Cc: gdb-patches@sourceware.org
Subject: Re: FYI: minsyms documentation
Date: Fri, 23 Dec 2011 10:38:00 -0000	[thread overview]
Message-ID: <20111223042053.GW23376@adacore.com> (raw)
In-Reply-To: <4EF38DAD.3040106@earthlink.net>

> I'm not liking this idea very much I'm afraid.

I don't have a strong opinion on this. I think you made some
good comments on the downside of this approach. But I also
think it does have some advantages as well.

I do think that...

> Doxygen output tends to make functions look more self-contained and
> well-defined than would actually be the case for most of GDB.

... is a weakness of our design, which makes it harder to use
as justification for another decision.

For me, I came to enjoy the fact that function descriptions can
always be found by locating the function implementation, which
in most cases is unique, and can be found using grep. But I also
recognize that many a times I have searched through the routines
applying to a given "object" searching for something that might
do what I want to do. Not having the documentation right next
to it was a real productivity hit.

So, perhaps the right approach lies in the middle. Only apply
Tom's approach to parts where it should in fact be an API. Things
like gdb_usleep, or vec.h are obvious candidates, for instance.
You've got to love how addrmap.h is documented, making it much
easier to use that module. And in the same vein, the "object"-like
structures that have use in GDB (symbols, symbol tables, values,
etc) could be documented similarly.

I should also mention this: One approach, followed by GNAT
engineers, is that they always have a declaration, either
in the package spec (header) or at the beginning of the package
body (.c file). And they always provide the function description
where the declaration is made. Should a function become public,
they move the whole blob, declaration and documentation to the
spec. I am not a fan, but if people like it, we can experiment
with that idea.

One thing I would like, though, is for all of us to insist on
every new function being documented. Even some GMs do not follow
or enforce this rule...

-- 
Joel


  parent reply	other threads:[~2011-12-23  4:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22  4:44 Tom Tromey
2011-12-22  5:17 ` Joel Brobecker
2011-12-22 20:13 ` Stan Shebs
2011-12-22 20:21   ` Tom Tromey
2011-12-22 21:06     ` Eli Zaretskii
2011-12-23  4:21       ` Stan Shebs
2011-12-23 16:01         ` Eli Zaretskii
2012-01-02 22:08           ` Tom Tromey
2012-01-03  8:17             ` Eli Zaretskii
2011-12-24  7:45         ` Yao Qi
2011-12-24 13:21           ` Eli Zaretskii
2012-01-02 22:08           ` Tom Tromey
2012-01-03  8:18             ` Eli Zaretskii
2011-12-22 21:18     ` Stan Shebs
2011-12-23 10:38   ` Joel Brobecker [this message]
2012-01-02 22:14     ` Tom Tromey
2012-01-03  2:53       ` Joel Brobecker
2012-01-03 11:05         ` Pedro Alves
2012-01-03 13:21           ` commands.h and cli/cli-decode.h dups (was: Re: FYI: minsyms documentation) Pedro Alves
2012-01-03 14:57             ` commands.h and cli/cli-decode.h dups Tom Tromey
2012-01-03 17:11               ` Joel Brobecker
2012-01-05 11:40                 ` Pedro Alves
2012-01-03 11:18 ` FYI: minsyms documentation Pedro Alves
2012-01-15 18:49 ` Michael Eager

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111223042053.GW23376@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=stanshebs@earthlink.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox