From: Doug Evans <xdje42@gmail.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 4/9] Explicit locations: introduce address locations
Date: Mon, 18 May 2015 05:45:00 -0000 [thread overview]
Message-ID: <m3a8x2qw1n.fsf@sspiff.org> (raw)
In-Reply-To: <20150507180554.19629.35641.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Thu, 07 May 2015 11:05:54 -0700")
Keith Seitz <keiths@redhat.com> writes:
> This patch adds support for address locations, of the form "*ADDR".
> [Support for address linespecs has been removed/replaced by this "new"
> location type.] This patch also converts any existing address locations
> from its previous linespec type.
>
> gdb/ChangeLog:
>
> * breakpoint.c (create_thread_event_breakpoint): Convert
> linespec to address location.
> (init_breakpoint_sal): Likewise.
> * linespec.c (canonicalize_linespec): Do not handle address
> locations here.
> (convert_address_location_to_sals): New function; contents moved
> from ...
> (convert_linespc_to_sals): ... here.
> (parse_linespec): Remove address locations from linespec grammar.
> Remove handling of address locations.
> (linespec_lex_to_end): Remove handling of address linespecs.
> (event_location_to_sals): Handle ADDRESS_LOCATION.
> (linespec_expression_to_pc): Export.
> * linespec.h (linespec_expression_to_pc): Add declaration.
> * location.c (struct event_location.u) <address>: New member.
> (new_address_location, get_address_location): New functions.
> (copy_event_location): Handle address locations.
> (delete_event_location): Likewise.
> (event_location_to_string): Likewise.
> (string_to_event_location): Likewise.
> (event_location_empty_p): Likewise.
> * location.h (enum event_location_type): Add ADDRESS_LOCATION.
> (new_address_location, get_address_location): Declare.
> * python/py-finishbreakpoint.c (bpfinishpy_init): Convert linespec
> to address location.
> * spu-tdep.c (spu_catch_start): Likewise.
LGTM
next prev parent reply other threads:[~2015-05-18 5:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 18:05 [PATCH v4 0/9] Locations API Keith Seitz
2015-05-07 18:05 ` [PATCH v4 2/9] Explicit locations: introduce new struct event_location-based API Keith Seitz
2015-05-17 20:54 ` Doug Evans
2015-05-19 20:41 ` Keith Seitz
2015-05-19 22:16 ` Pedro Alves
2015-05-07 18:06 ` [PATCH v4 6/9] Explicit locations: introduce explicit locations Keith Seitz
2015-05-18 6:13 ` Doug Evans
2015-05-18 20:14 ` Keith Seitz
2015-05-19 22:09 ` Pedro Alves
2015-05-19 22:12 ` Keith Seitz
2015-05-19 22:15 ` Pedro Alves
2015-05-19 22:20 ` Keith Seitz
2015-05-21 19:34 ` [PATCH v5] Explicit locations: add UI features for CLI Keith Seitz
2015-05-27 4:43 ` [PATCH v4 6/9] Explicit locations: introduce explicit locations Doug Evans
2015-05-27 11:36 ` Matt Rice
2015-05-30 15:17 ` Matt Rice
2015-05-07 18:06 ` [PATCH v4 3/9] Explicit locations: use new location API Keith Seitz
2015-05-18 5:21 ` Doug Evans
2015-05-19 21:30 ` Keith Seitz
2015-05-07 18:06 ` [PATCH v4 5/9] Explicit locations: introduce probe locations Keith Seitz
2015-05-18 5:49 ` Doug Evans
2015-05-07 18:06 ` [PATCH v4 7/9] Explicit locations: add UI features for CLI Keith Seitz
2015-05-18 6:55 ` Doug Evans
2015-05-19 20:41 ` Keith Seitz
2015-05-27 4:27 ` Doug Evans
2015-05-07 18:06 ` [PATCH v4 8/9] Explicit locations: MI support for explicit locations Keith Seitz
2015-05-18 7:16 ` Doug Evans
2015-05-07 18:06 ` [PATCH v4 1/9] Explicit locations: rename "address string"/"addr_string" to "location" Keith Seitz
2015-05-17 20:10 ` Doug Evans
2015-05-07 18:06 ` [PATCH v4 4/9] Explicit locations: introduce address locations Keith Seitz
2015-05-18 5:45 ` Doug Evans [this message]
2015-05-07 18:13 ` [PATCH v4 9/9] Explicit locations: documentation updates Keith Seitz
2015-05-07 18:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3a8x2qw1n.fsf@sspiff.org \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox