From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66840 invoked by alias); 18 May 2015 05:45:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66827 invoked by uid 89); 18 May 2015 05:45:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f53.google.com Received: from mail-pa0-f53.google.com (HELO mail-pa0-f53.google.com) (209.85.220.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 18 May 2015 05:45:32 +0000 Received: by pabts4 with SMTP id ts4so137048526pab.3 for ; Sun, 17 May 2015 22:45:30 -0700 (PDT) X-Received: by 10.68.252.106 with SMTP id zr10mr41444965pbc.79.1431927930465; Sun, 17 May 2015 22:45:30 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id u8sm8705920pdj.46.2015.05.17.22.45.29 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 May 2015 22:45:29 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v4 4/9] Explicit locations: introduce address locations References: <20150507180523.19629.77846.stgit@valrhona.uglyboxes.com> <20150507180554.19629.35641.stgit@valrhona.uglyboxes.com> Date: Mon, 18 May 2015 05:45:00 -0000 In-Reply-To: <20150507180554.19629.35641.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Thu, 07 May 2015 11:05:54 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00452.txt.bz2 Keith Seitz writes: > This patch adds support for address locations, of the form "*ADDR". > [Support for address linespecs has been removed/replaced by this "new" > location type.] This patch also converts any existing address locations > from its previous linespec type. > > gdb/ChangeLog: > > * breakpoint.c (create_thread_event_breakpoint): Convert > linespec to address location. > (init_breakpoint_sal): Likewise. > * linespec.c (canonicalize_linespec): Do not handle address > locations here. > (convert_address_location_to_sals): New function; contents moved > from ... > (convert_linespc_to_sals): ... here. > (parse_linespec): Remove address locations from linespec grammar. > Remove handling of address locations. > (linespec_lex_to_end): Remove handling of address linespecs. > (event_location_to_sals): Handle ADDRESS_LOCATION. > (linespec_expression_to_pc): Export. > * linespec.h (linespec_expression_to_pc): Add declaration. > * location.c (struct event_location.u)
: New member. > (new_address_location, get_address_location): New functions. > (copy_event_location): Handle address locations. > (delete_event_location): Likewise. > (event_location_to_string): Likewise. > (string_to_event_location): Likewise. > (event_location_empty_p): Likewise. > * location.h (enum event_location_type): Add ADDRESS_LOCATION. > (new_address_location, get_address_location): Declare. > * python/py-finishbreakpoint.c (bpfinishpy_init): Convert linespec > to address location. > * spu-tdep.c (spu_catch_start): Likewise. LGTM