From: Doug Evans <xdje42@gmail.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 1/9] Explicit locations: rename "address string"/"addr_string" to "location"
Date: Sun, 17 May 2015 20:10:00 -0000 [thread overview]
Message-ID: <m3zj53t18s.fsf@sspiff.org> (raw)
In-Reply-To: <20150507180546.19629.73286.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Thu, 07 May 2015 11:05:46 -0700")
Keith Seitz <keiths@redhat.com> writes:
> This patch renames all occurrances of "addr_string" and "address
> string" in the breakpoint/linespec APIs. This will emphasize the
> change from address strings used in setting breakpoints (et al) to the
> new locations-based API introduced in subsequent patches.
>
> gdb/ChangeLog:
>
> * breakpoint.h (struct breakpoint_ops) <create_sals_from_address>:
> Renamed to create_sals_from_location.
> <decode_linespec>: Renamed to decode_location.
> Update all callers.
> * breakpoint.c (create_sals_from_address_default): Renamed to ...
> (create_sals_from_location_default): ... this.
> (addr_string_to_sals): Renamed to ...
> (location_to_sals): ... this.
> (decode_linespec_default): Renamed to ...
> (decode_location_default): ... this.
> (base_breakpoint_create_sals_from_address): Renamed to ...
> (base_breakpoint_create_sals_from_location): ... this.
> (bkpt_create_sals_from_address): Renamed to ...
> (bkpt_create_sals_from_location): ... this.
> (bkpt_decode_linespec): Renamed to ...
> (bkpt_decode_location): ... this.
> (bkpt_probe_create_sals_from_address): Renamed to ...
> (bkpt_probe_create_sals_from_location): ... this.
> (tracepoint_create_sals_from_address): Renamed to ...
> (tracepoint_create_sals_from_location): ... this.
> (tracepoint_decode_linespec): Renamed to ...
> (tracepoint_decode_location): ... this.
> (tracepoint_probe_create_sals_from_address): Renamed to ...
> (tracepoint_probe_create_sals_from_location): ... this.
> (tracepoint_probe_decode_linespec): Renamed to ...
> (tracepoint_probe_decode_location): ... this.
> (strace_marker_create_sals_from_address): Renamed to ...
> (strace_marker_create_sals_from_location): ... this.
> (decode_linespec_default): Renamed to ...
> (decode_location_default): ... this.
LGTM
next prev parent reply other threads:[~2015-05-17 20:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 18:05 [PATCH v4 0/9] Locations API Keith Seitz
2015-05-07 18:05 ` [PATCH v4 2/9] Explicit locations: introduce new struct event_location-based API Keith Seitz
2015-05-17 20:54 ` Doug Evans
2015-05-19 20:41 ` Keith Seitz
2015-05-19 22:16 ` Pedro Alves
2015-05-07 18:06 ` [PATCH v4 5/9] Explicit locations: introduce probe locations Keith Seitz
2015-05-18 5:49 ` Doug Evans
2015-05-07 18:06 ` [PATCH v4 3/9] Explicit locations: use new location API Keith Seitz
2015-05-18 5:21 ` Doug Evans
2015-05-19 21:30 ` Keith Seitz
2015-05-07 18:06 ` [PATCH v4 6/9] Explicit locations: introduce explicit locations Keith Seitz
2015-05-18 6:13 ` Doug Evans
2015-05-18 20:14 ` Keith Seitz
2015-05-19 22:09 ` Pedro Alves
2015-05-19 22:12 ` Keith Seitz
2015-05-19 22:15 ` Pedro Alves
2015-05-19 22:20 ` Keith Seitz
2015-05-21 19:34 ` [PATCH v5] Explicit locations: add UI features for CLI Keith Seitz
2015-05-27 4:43 ` [PATCH v4 6/9] Explicit locations: introduce explicit locations Doug Evans
2015-05-27 11:36 ` Matt Rice
2015-05-30 15:17 ` Matt Rice
2015-05-07 18:06 ` [PATCH v4 4/9] Explicit locations: introduce address locations Keith Seitz
2015-05-18 5:45 ` Doug Evans
2015-05-07 18:06 ` [PATCH v4 8/9] Explicit locations: MI support for explicit locations Keith Seitz
2015-05-18 7:16 ` Doug Evans
2015-05-07 18:06 ` [PATCH v4 1/9] Explicit locations: rename "address string"/"addr_string" to "location" Keith Seitz
2015-05-17 20:10 ` Doug Evans [this message]
2015-05-07 18:06 ` [PATCH v4 7/9] Explicit locations: add UI features for CLI Keith Seitz
2015-05-18 6:55 ` Doug Evans
2015-05-19 20:41 ` Keith Seitz
2015-05-27 4:27 ` Doug Evans
2015-05-07 18:13 ` [PATCH v4 9/9] Explicit locations: documentation updates Keith Seitz
2015-05-07 18:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zj53t18s.fsf@sspiff.org \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox