Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit/dwarf] Create partial symbols for nested 	subprograms
Date: Fri, 12 Sep 2008 17:19:00 -0000	[thread overview]
Message-ID: <m38wtxxp0e.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20080912165541.GE3714@adacore.com> (Joel Brobecker's message of "Fri\, 12 Sep 2008 09\:55\:41 -0700")

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Tom> My patch defers reading partial symbol tables until they are needed.
Tom> This is done on a per-objfile basis, so some user requests can be
Tom> satisfied without reading all the psymbols for the inferior.

Joel> Oh, wow. How do you detect when partial symbols are needed or not?

To find the places needing a call to require_partial_symbols, first I
read a bunch of code, then I ran the test suite, and finally I did
some interactive tests while debugging the modified gdb.

Essentially, the drawback of this approach is that, before writing
code that uses psymbols, you must decide whether they should be loaded
or not.

In some cases, other sorts of changes are appropriate.  E.g., I
changed have_partial_symbols() to have two loops -- one that first
checks whether any partial symbols exist, and then a second to try to
demand-load partial symbols.

Joel> (it's ok if you don't have time to answer my question now - I will
Joel> find out anyways when you do submit the patch here, so...)

If you want to see it sooner, I posted it to the archer list.
Also it is in the archer git repository.

Tom


  reply	other threads:[~2008-09-12 17:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-10 20:20 Joel Brobecker
2008-09-10 20:35 ` Daniel Jacobowitz
2008-09-10 21:38   ` Tom Tromey
2008-09-11  5:01     ` Joel Brobecker
2008-09-11 22:15       ` Tom Tromey
2008-09-11 22:28         ` Daniel Jacobowitz
2008-09-11 22:33           ` Tom Tromey
2008-09-12  4:19           ` Joel Brobecker
2008-09-11 17:55   ` Joel Brobecker
2008-09-11 18:38     ` Daniel Jacobowitz
2008-09-11 21:53       ` Joel Brobecker
2008-09-13 15:14         ` Daniel Jacobowitz
2008-09-13 22:21           ` Joel Brobecker
2008-09-11 22:44       ` Tom Tromey
2008-09-12  4:18         ` Joel Brobecker
2008-09-12 16:51           ` Tom Tromey
2008-09-12 16:56             ` Joel Brobecker
2008-09-12 17:19               ` Tom Tromey [this message]
2008-09-12 17:43                 ` Joel Brobecker
2008-09-12 18:08                   ` Tom Tromey
2008-09-12 18:43                   ` Frank Ch. Eigler
2008-09-12 20:31                     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m38wtxxp0e.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox