From: Tom Tromey <tromey@redhat.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [obvious] Remove unused argument in insert_bp_location
Date: Mon, 01 Aug 2011 14:41:00 -0000 [thread overview]
Message-ID: <m38vrd6vos.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1312144543.13977.3.camel@hactar> (Thiago Jung Bauermann's message of "Sun, 31 Jul 2011 17:35:43 -0300")
>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
Thiago> I noticed that disabled_breakpoints is not used. It's both an input and
Thiago> output parameter. All callers set it to zero, and none of them checks
Thiago> its value on return.
Thiago> 2011-07-31 Thiago Jung Bauermann <bauerman@br.ibm.com>
Thiago> * breakpoint.c (insert_bp_location): Remove disabled_breaks
Thiago> argument. Update callers.
I don't think this patch is really equivalent to the previous code.
To me it seems that *disabled_breaks was being used as a persistent flag.
That is, the caller doesn't check its value, but subsequent calls to
insert_bp_location do -- the value is not reset in the ALL_BP_LOCATIONS
loop in insert_breakpoint_locations.
Tom
next prev parent reply other threads:[~2011-08-01 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-31 20:44 Thiago Jung Bauermann
2011-08-01 14:41 ` Tom Tromey [this message]
2011-08-01 18:34 ` Thiago Jung Bauermann
2011-08-01 18:50 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38vrd6vos.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox