From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14042 invoked by alias); 1 Aug 2011 14:41:45 -0000 Received: (qmail 14034 invoked by uid 22791); 1 Aug 2011 14:41:44 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Aug 2011 14:41:30 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p71EfPhS011120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 1 Aug 2011 10:41:25 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p71EfO57005349; Mon, 1 Aug 2011 10:41:25 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p71EfNOi021611; Mon, 1 Aug 2011 10:41:23 -0400 From: Tom Tromey To: Thiago Jung Bauermann Cc: gdb-patches ml Subject: Re: [obvious] Remove unused argument in insert_bp_location References: <1312144543.13977.3.camel@hactar> Date: Mon, 01 Aug 2011 14:41:00 -0000 In-Reply-To: <1312144543.13977.3.camel@hactar> (Thiago Jung Bauermann's message of "Sun, 31 Jul 2011 17:35:43 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00012.txt.bz2 >>>>> "Thiago" == Thiago Jung Bauermann writes: Thiago> I noticed that disabled_breakpoints is not used. It's both an input and Thiago> output parameter. All callers set it to zero, and none of them checks Thiago> its value on return. Thiago> 2011-07-31 Thiago Jung Bauermann Thiago> * breakpoint.c (insert_bp_location): Remove disabled_breaks Thiago> argument. Update callers. I don't think this patch is really equivalent to the previous code. To me it seems that *disabled_breaks was being used as a persistent flag. That is, the caller doesn't check its value, but subsequent calls to insert_bp_location do -- the value is not reset in the ALL_BP_LOCATIONS loop in insert_breakpoint_locations. Tom