From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: gdb-patches ml <gdb-patches@sourceware.org>
Subject: [obvious] Remove unused argument in insert_bp_location
Date: Sun, 31 Jul 2011 20:44:00 -0000 [thread overview]
Message-ID: <1312144543.13977.3.camel@hactar> (raw)
Hi,
I noticed that disabled_breakpoints is not used. It's both an input and
output parameter. All callers set it to zero, and none of them checks
its value on return.
Committed the following (there were no regressions on i386-linux).
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center
2011-07-31 Thiago Jung Bauermann <bauerman@br.ibm.com>
* breakpoint.c (insert_bp_location): Remove disabled_breaks
argument. Update callers.
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 00fe748..edfa661 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -1573,14 +1573,13 @@ should_be_inserted (struct bp_location *bl)
/* Insert a low-level "breakpoint" of some type. BL is the breakpoint
location. Any error messages are printed to TMP_ERROR_STREAM; and
- DISABLED_BREAKS, and HW_BREAKPOINT_ERROR are used to report problems.
+ HW_BREAKPOINT_ERROR is used to report problems.
NOTE drow/2003-09-09: This routine could be broken down to an
object-style method for each breakpoint or catchpoint type. */
static int
insert_bp_location (struct bp_location *bl,
struct ui_file *tmp_error_stream,
- int *disabled_breaks,
int *hw_breakpoint_error)
{
int val = 0;
@@ -1714,16 +1713,12 @@ insert_bp_location (struct bp_location *bl,
val = 0;
bl->shlib_disabled = 1;
observer_notify_breakpoint_modified (bl->owner);
- if (!*disabled_breaks)
- {
- fprintf_unfiltered (tmp_error_stream,
- "Cannot insert breakpoint %d.\n",
- bl->owner->number);
- fprintf_unfiltered (tmp_error_stream,
- "Temporarily disabling shared "
- "library breakpoints:\n");
- }
- *disabled_breaks = 1;
+ fprintf_unfiltered (tmp_error_stream,
+ "Cannot insert breakpoint %d.\n",
+ bl->owner->number);
+ fprintf_unfiltered (tmp_error_stream,
+ "Temporarily disabling shared "
+ "library breakpoints:\n");
fprintf_unfiltered (tmp_error_stream,
"breakpoint #%d\n", bl->owner->number);
}
@@ -1914,7 +1909,6 @@ insert_breakpoint_locations (void)
struct bp_location *bl, **blp_tmp;
int error = 0;
int val = 0;
- int disabled_breaks = 0;
int hw_breakpoint_error = 0;
struct ui_file *tmp_error_stream = mem_fileopen ();
@@ -1948,8 +1942,8 @@ insert_breakpoint_locations (void)
&& ptid_equal (inferior_ptid, null_ptid))
continue;
- val = insert_bp_location (bl, tmp_error_stream, &disabled_breaks,
- &hw_breakpoint_error);
+ val = insert_bp_location (bl, tmp_error_stream,
+ &hw_breakpoint_error);
if (val)
error = val;
}
@@ -2052,7 +2046,7 @@ reattach_breakpoints (int pid)
struct bp_location *bl, **blp_tmp;
int val;
struct ui_file *tmp_error_stream;
- int dummy1 = 0, dummy2 = 0;
+ int dummy = 0;
struct inferior *inf;
struct thread_info *tp;
@@ -2076,7 +2070,7 @@ reattach_breakpoints (int pid)
if (bl->inserted)
{
bl->inserted = 0;
- val = insert_bp_location (bl, tmp_error_stream, &dummy1, &dummy2);
+ val = insert_bp_location (bl, tmp_error_stream, &dummy);
if (val != 0)
{
do_cleanups (old_chain);
next reply other threads:[~2011-07-31 20:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-31 20:44 Thiago Jung Bauermann [this message]
2011-08-01 14:41 ` Tom Tromey
2011-08-01 18:34 ` Thiago Jung Bauermann
2011-08-01 18:50 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312144543.13977.3.camel@hactar \
--to=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox