From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Marcus Shawcroft <marcus.shawcroft@arm.com>
Subject: Re: [PATCH] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64
Date: Wed, 04 Dec 2013 23:33:00 -0000 [thread overview]
Message-ID: <m38uw0kx8v.fsf@redhat.com> (raw)
In-Reply-To: <87wqjt222h.fsf@fleche.redhat.com> (Tom Tromey's message of "Wed, 27 Nov 2013 10:21:10 -0700")
On Wednesday, November 27 2013, Tom Tromey wrote:
> FWIW in this specific case I think this testing approach is ok.
> The patch pretty clearly just touches the stap probe code.
> Could you say, though, exactly which tests you ran?
Thanks. For this case, I ran manually the tests from
gdb.base/stap-probe.exp, checking the results and making sure everything
is working OK.
Since the AArch64 asm permits more than one numeric literal prefix to be
used, I hacked the generated assembly in order to test this too. Soon I
will post a patch that extends the current generic parser to accept
multiple prefixes/suffixes, and then I will repost this AArch64 support
patch on top of it.
--
Sergio
prev parent reply other threads:[~2013-12-04 23:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 23:48 Sergio Durigan Junior
2013-11-25 12:18 ` Marcus Shawcroft
2013-11-25 23:55 ` Sergio Durigan Junior
2013-11-26 10:13 ` Marcus Shawcroft
2013-11-27 17:52 ` Tom Tromey
2013-12-04 23:35 ` Sergio Durigan Junior
2013-11-27 17:32 ` Tom Tromey
2013-12-04 23:33 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38uw0kx8v.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=marcus.shawcroft@arm.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox