From: Tom Tromey <tromey@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Marcus Shawcroft <marcus.shawcroft@arm.com>
Subject: Re: [PATCH] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64
Date: Wed, 27 Nov 2013 17:32:00 -0000 [thread overview]
Message-ID: <87wqjt222h.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1385336092-19621-1-git-send-email-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Sun, 24 Nov 2013 21:34:52 -0200")
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> Now, about the tests... I have been using ARM Foundation's simulator
Sergio> on x86_64 (Fedora 18). This is an incredibly slow simulator, to the
Sergio> point that I gave up compiling GDB directly on it. Instead, I am
Sergio> cross-compiling it on my machine and testing only the binary there.
Sergio> Therefore, I also gave up running the testsuite, and only ran
Sergio> stap-related tests. As far as I'm concerned, everything succeeded and
Sergio> I didn't break anything. The code is pretty much self contained that
Sergio> it doesn't affect other areas of GDB, but of course this patch could
Sergio> use more testing, and I won't complain if you have the means and the
Sergio> will to do this!
FWIW in this specific case I think this testing approach is ok.
The patch pretty clearly just touches the stap probe code.
Could you say, though, exactly which tests you ran?
Tom
next prev parent reply other threads:[~2013-11-27 17:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 23:48 Sergio Durigan Junior
2013-11-25 12:18 ` Marcus Shawcroft
2013-11-25 23:55 ` Sergio Durigan Junior
2013-11-26 10:13 ` Marcus Shawcroft
2013-11-27 17:52 ` Tom Tromey
2013-12-04 23:35 ` Sergio Durigan Junior
2013-11-27 17:32 ` Tom Tromey [this message]
2013-12-04 23:33 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqjt222h.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=marcus.shawcroft@arm.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox