From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20616 invoked by alias); 27 Nov 2013 17:21:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20602 invoked by uid 89); 27 Nov 2013 17:21:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2013 17:21:22 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rARHLCq5003227 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Nov 2013 12:21:12 -0500 Received: from barimba (ovpn-113-124.phx2.redhat.com [10.3.113.124]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rARHLA9J004930 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 27 Nov 2013 12:21:11 -0500 From: Tom Tromey To: Sergio Durigan Junior Cc: GDB Patches , Marcus Shawcroft Subject: Re: [PATCH] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64 References: <1385336092-19621-1-git-send-email-sergiodj@redhat.com> Date: Wed, 27 Nov 2013 17:32:00 -0000 In-Reply-To: <1385336092-19621-1-git-send-email-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Sun, 24 Nov 2013 21:34:52 -0200") Message-ID: <87wqjt222h.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00849.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> Now, about the tests... I have been using ARM Foundation's simulator Sergio> on x86_64 (Fedora 18). This is an incredibly slow simulator, to the Sergio> point that I gave up compiling GDB directly on it. Instead, I am Sergio> cross-compiling it on my machine and testing only the binary there. Sergio> Therefore, I also gave up running the testsuite, and only ran Sergio> stap-related tests. As far as I'm concerned, everything succeeded and Sergio> I didn't break anything. The code is pretty much self contained that Sergio> it doesn't affect other areas of GDB, but of course this patch could Sergio> use more testing, and I won't complain if you have the means and the Sergio> will to do this! FWIW in this specific case I think this testing approach is ok. The patch pretty clearly just touches the stap probe code. Could you say, though, exactly which tests you ran? Tom